This is a relic from the etcd integration and only used to remove in the
final answer returned to the client. We do need it. Make it a constant
and only one character wide.
Signed-off-by: Miek Gieben <miek@miek.nl>

These maps where all map[x]bool. Change this a map[x]struct{} as this
is smaller and we only use these map to signal "this element exists".

This should preserve a (small) amount of memory.
Signed-off-by: Miek Gieben <miek@miek.nl>

Make the NewSRV and friends slightly smarter. Optimize the calling of
targetStrip which is almost certainly not used.

Added benchmark show a modest improvement:

benchmark             old ns/op     new ns/op     delta
BenchmarkNewSRV-4     300           283           -5.67%
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix EDNS0 compliance

Do SizeAndDo in the server (ScrubWriter) and remove all uses of this
from the plugins. Also *always* do it. This is to get into compliance
for https://dnsflagday.net/.

The pkg/edns0 now exports the EDNS0 options we understand; this is
exported to allow plugins add things there. The *rewrite* plugin used
this to add custom EDNS0 option codes that the server needs to
understand.

This also needs a new release of miekg/dns because it triggered a
race-condition that was basicly there forever.

See:
* https://github.com/miekg/dns/issues/857
* https://github.com/miekg/dns/pull/859

Running a test instance and pointing the https://ednscomp.isc.org/ednscomp
to it shows the tests are now fixed:

~~~
EDNS Compliance Tester
Checking: 'miek.nl' as at 2018-12-01T17:53:15Z

miek.nl. @147.75.204.203 (drone.coredns.io.): dns=ok edns=ok edns1=ok edns@512=ok ednsopt=ok edns1opt=ok do=ok ednsflags=ok docookie=ok edns512tcp=ok optlist=ok
miek.nl. @2604:1380:2002:a000::1 (drone.coredns.io.): dns=ok edns=ok edns1=ok edns@512=ok ednsopt=ok edns1opt=ok do=ok ednsflags=ok docookie=ok edns512tcp=ok optlist=ok

All Ok
Codes
ok - test passed.
~~~
Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>

* typos in comments
Signed-off-by: Miek Gieben <miek@miek.nl>

Automatically submitted.

Automatically submitted.

* improve loop troubleshoot docs

* fix spelling

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

I think this is causing problem and it will actually clash with the
scrubbing that now happens for all plugins anyway. We're assuming the
returned message will be valid even with tc being set. request.Scrub
follows that same logic.
Signed-off-by: Miek Gieben <miek@miek.nl>

* pkg/up: implement backoff

Every 2nd failure we double the interval until we hit 4 * interval. This
to have some sort of backoff, esp when a large cluster of coredns shares
an upstream (original intent of up package) they will hammer the
upstream. This put some back pressure on that.
Signed-off-by: Miek Gieben <miek@miek.nl>

* Update plugin/pkg/up/up.go
Co-Authored-By: miekg <miek@miek.nl>

We're not doing anything with the data so stop doing it. Also makes
travis 20% faster.
Signed-off-by: Miek Gieben <miek@miek.nl>

Upgrade to new dns lib version; that saw multiple improvements; some
patch releases are in the pipeline.

The big thing here is the removal of ErrTruncated, so we need to deal
with this slightly different in the forward plugin. It removed the
entire truncated.go logic and just checks the message for .Truncated (if
there is a message) and retries with tcp.
Signed-off-by: Miek Gieben <miek@miek.nl>

Textual cleanup.

Miscellaneous textual cleanup.

Signed-off-by: Miek Gieben <miek@miek.nl>

The loadbalancer plugin reorders records. It was doing this for zone
transfers - if you had a CNAME in the zone then your transfer would
be broken because it would get put before the SOA record.

Automatically submitted.

* plugin/forward: remove dynamic read timeout

We care about an upstream being there, so we still have a dynamic dial
time out (by way higher then 200ms) of 1s; this should be fairly stable
for an upstream. The read timeout if more variable because of cached and
non cached responses. As such remove his logic entirely.

Drop to 2s read timeout.

Fixes #2306
Signed-off-by: Miek Gieben <miek@miek.nl>

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Set SOA record TTL as min of TTL/MINIMUM

According to
https://tools.ietf.org/html/rfc2308#section-3:

  The TTL of this record is set from the minimum
  of the MINIMUM field of the SOA record and the
  TTL of the SOA itself, and indicates how long a
  resolver may cache the negative answer.

Set the TTL accordingly so as to not always
negative cache SOA records for 300 seconds.

* Inline min func

* Update SOA record tests

* Fix types

* Redo the plugin log PR

Remove the code duplication and call of the "official" functions. This
is the second(?) time we forgot to update the other half, so remove that
problem entirely.

Also add a test if the correct (within limits) time in front of the log
line.
Signed-off-by: Miek Gieben <miek@miek.nl>

* Remove pFormat
Signed-off-by: Miek Gieben <miek@miek.nl>

* Add email

* Add my affiliated organization (Infoblox)

* Add email next to my github handle

Following Governance description, I add my email next to my github handle.

I would need for CNCF Graduation to show the different organizations the maintainers are from. Anyone with no email or personal email (like gmail) will be considered under its own organization.

That would also help when vote will come-in, as we restraint votes for people on the same organization.

@miekg :
* I guess that will need change in the dreck project that parse this file.
* Do you want me to PR the change on that project (miek/dreck) ?

* Update with a comment
Co-Authored-By: fturib <ftur@infoblox.com>

Based on comment:
https://github.com/coredns/coredns/pull/2298#issuecomment-438473086Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Project lead

This change is considered as part of the GOVERNANCE.md update (11/12/2018)
to add the project lead in OWNERS file. The term (11/12/2019) aligns
with GOVERNANCE.md update.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Change term to 11/11/2019, as it should be part of the GOVERNANCE.md update (11/12/2018)
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Update to use comment
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* check allowed transfers

* add tests for parsing, and comment about refactor

* Update GOVERNANCE.md

* feedback

* capitalize CNCF

999 chops of suffix zero, 000 allows for the milliseconds to be always
printed with 3 chars. This makes the log the printed with the same
columns.

(partial logs below)

2018-11-13T21:13:28.249Z [INFO] [::1]
2018-11-13T21:13:48.414Z [INFO] [::1]
2018-11-13T21:13:49.1Z [INFO] [::1]

vs:

2018-11-13T21:20:22.262Z [INFO] [::1]
2018-11-13T21:20:22.436Z [INFO] [::1]
2018-11-13T21:20:22.608Z [INFO] [::1]
Signed-off-by: Miek Gieben <miek@miek.nl>

Update README.md in route53 plugin, as credentials_file is
not supported.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* - add metadata support to Log

* - adapt ctx after rebase

Automatically submitted.

Automatically submitted.