* Move functions from pkg/transport to pkg/parse

Although "parse" is a fairly generic name I believe this is somewhat
better named. pkg/transport keeps a few constants that are uses
throughout for the rest is is renaming a bunch (and the fallout from
there to make things compile again).
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl>

Create plugin/pkg/transport that holds the transport related functions.
This needed to be a new pkg to prevent cyclic import errors.

This cleans up a bunch of duplicated code in core/dnsserver that also
tried to parse a transport (now all done in transport.Parse).
Signed-off-by: Miek Gieben <miek@miek.nl>

* [plugin/route53]: Support batch mode operation.

Cache all Route53 records internally using `ListResourceRecordPagesWithContext`
and serve them from memory.

Bonus features:

  * Support additional r53 record types (`CNAME`, `SOA`, etc)
  * Support `upstream` option (#2099 filed to support argument optionality)
Signed-off-by: Dmitry Ilyevskiy <dmitry.ilyevskiy@getcruise.com>
Signed-off-by: Dmitry Ilyevskiy <ilyevsky@gmail.com>

* [plugin/proxy]: Return on WriteMsg err.

Followup PR on the heels of #2050. Short-circut and log on error from
`WriteMsg`. This will prevent code getting stuck on `ReadMsg` and allow
for easier debugging.

Also simply the `ReadMsg` calling code a little - remove double `Close` (already called above).

* Add @dilyevsky to reviewers.

Per @miekg suggestion on https://github.com/coredns/coredns/pull/2050#pullrequestreview-149538954
adding myself to OWNERS file.

* Also add me into plugin/route53-specific reviewers/approvers.

* handle missing avail-zone/region labels better

* oops forgot a file

* Add success min TTL parameter to cache.

* Add MINTTL to README.

* Update README.

* Add MINTTL to negative cache.

* Remove unnecessary variable name.

* Address review comments.

* Configure cache in TestCacheZeroTTL to have 0 min ttl.

* - change Key for cache to 64bits.

* - change Key for cache to 64bits.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

Update the how to release notes in Makefile.release
And some little community tweaks in the README.md
Signed-off-by: Miek Gieben <miek@miek.nl>

Signed-off-by: Miek Gieben <miek@miek.nl>

Resolves: #1981
Signed-off-by: Paul Greenberg <greenpau@outlook.com>

Just create the sha256 inline so we know there are there.
Add a 'version' target in Makefile.release that prints the version so we
can double check that easily in the release script.
Signed-off-by: Miek Gieben <miek@miek.nl>

Every plugin needs to deal with EDNS0 and should call Scrub to make a
message fit the client's buffer. Move this functionality into the server
and wrapping the ResponseWriter into a ScrubWriter that handles these
bits for us. Result:

Less code and faster, because multiple chained plugins could all be
calling scrub and SizeAndDo - now there is just one place.

Most tests in file/* and dnssec/* needed adjusting because in those unit
tests you don't see OPT RRs anymore. The DNSSEC signer was also looking
at the returned OPT RR to see if it needed to sign - as those are now
added by the server (and thus later), this needed to change slightly.

Scrub itself still exist (for backward compat reasons), but has been
made a noop. Scrub has been renamed to scrub as it should not be used by
external plugins.

Fixes: #2010
Signed-off-by: Miek Gieben <miek@miek.nl>

* Bump version to 1.2.2

Release 1.2.2
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix filename to what we upload

With ls dir/* the pathname returned are diff. then we with ls dir, fix
how curl is called.
Signed-off-by: Miek Gieben <miek@miek.nl>

For the 1.2.1 release we didn't upload the sha256 files. I've added
an echo, but some testing suggests that the files are created, so the
problem lays somewhere else.

Add a new upload section that sets the content type correctly and POST
the files as text/plain.
Signed-off-by: Miek Gieben <miek@miek.nl>

help debug why the assets' sha256 files weren't upload to github.
Signed-off-by: Miek Gieben <miek@miek.nl>

up the version and add the man-pages.
Signed-off-by: Miek Gieben <miek@miek.nl>

dont transfer unexposed namespaces

inject sentinels for portless services

fix #2038
Signed-off-by: bingshen.wbs <bingshen.wbs@alibaba-inc.com>

* Update README.md

* Update README.md

* Create test to verify correct listener behavior

* Create Unset function to remove todo items

* Reset address for prometheus listener before restarting

* Add inline documentation for Unset function

* Make shutdownTimeout a constant and change to five seconds

* Revert ForEach behavior in uniq package

* - 12 more Adopters, extracted from the survey "CoreDNS Adoption"

- surver for "CoreDNS Adoption" is out since one week. on 3 of 15 replies, adopters provide their names and agree to be part of this list (#2025)

Automatically submitted.

This fix adds exe extension to Windows release binary.

This fix fixes 2021.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* - invite users to fill the survey

* Update README.md

Automatically submitted.

The exit code wasn't properly acted upon in the makefile.
Make filename-hyphen actually return an non-zero exit code.
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix ineffassign

This fix tries to fix ineffassign, as was reported in:
https://goreportcard.com/report/github.com/coredns/coredns#ineffassignSigned-off-by: Yong Tang <yong.tang.github@outlook.com>

* Update setup.go

Revert this one change, so this can be merged.

* Add regression test for broken DNS truncation

With the latest changes to the implementation, request.Scrub() returns
invalid response messages which are larger than the advertised buffer
size. This commit adds a failing test for that.

* Add benchmark for response truncation

* request: re-adjust size for edns0 RR

Cherry-picked the test and benchmark commits from #1962 and make the
failing test not fail, by adding minimal fix in request.go.

This makes size 12 bytes smaller if we need to add back the OPT RR in
the message.

Closes: #1962
Signed-off-by: Miek Gieben <miek@miek.nl>

* Scrub: correctly check for EDNS0, not only Do

Make Scrub check for EDNS0, not only if the Do bit is set.
Signed-off-by: Miek Gieben <miek@miek.nl>

This downloads gometalinter (which is now breaking in the CI tests).
Also the goimports target is run with ||true, so nothing will break
if this flags anything (done because of gofmt changes in between
release).

Probably I will setup something to use github's linter API:
https://github.com/markstory/lint-reviewSigned-off-by: Miek Gieben <miek@miek.nl>

Signed-off-by: Miek Gieben <miek@miek.nl>