Skip to content

C
Coredns
Switch branch/tag
This project is mirrored from https://github.com/coredns/coredns.git. The repository failed to update .
Repository mirroring has been paused due to too many failed attempts, and can be resumed by a project maintainer.
Last successful update .
  1. 14 Oct, 2020 2 commits
    • Miek Gieben's avatar
      plugin/cache: fix removing OPT (#4190) · be09f473
      Miek Gieben authored 
      By checking state.Do() were are checking if the request had DO, but
we are _always_ adding Do now - do we need to save the DO from the
ORIGINAL request, which must be done in the ResponseWriter.

Also skip OPT records in filterDNSSEC as we can't set the TTL on those
records, this prevents writing a number to OPT's MBZ.

Note none of the tests have changed and still PASS. This is due to
the fact that CoreDNSServerAndPorts isn't a full server as we start in
main, it lacks the scrubwriter for instance. This is not bad per se, but
should be documented in the test code.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      be09f473
    • Miek Gieben's avatar
      notes: add dnstap PR (#4197) · 34dc59fc
      Miek Gieben authored 
      few notes that this API also changed.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      34dc59fc
  3. 13 Oct, 2020 3 commits
  5. 12 Oct, 2020 8 commits
  7. 08 Oct, 2020 1 commit
  9. 07 Oct, 2020 1 commit
    • Miek Gieben's avatar
      core: fix crash with no plugins (#4184) · 04e532b2
      Miek Gieben authored 
      * core: fix crash with no plugins

A Corefile that defines a zone without plugins crashes coredns with the
stack trace below. Change this to return a refused.

~~~ corefile
 example.org {
    whoami
    log
    cache
    debug
}

example.net {
}
~~~

Asking for anyhing in example.net does this. Add test that tests this.

~~~
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xa5e6a4]

goroutine 55 [running]:
github.com/coredns/coredns/core/dnsserver.(*Server).ServeDNS(0xc000438f60, 0x2059420, 0xc0005a4030, 0x206c0e0, 0xc000522140, 0xc0005ae000)
	/home/miek/src/github.com/coredns/coredns/core/dnsserver/server.go:247 +0x884
github.com/coredns/coredns/core/dnsserver.(*Server).ServePacket.func1(0x206dd00, 0xc00009e180, 0xc0005ae000)
	/home/miek/src/github.com/coredns/coredns/core/dnsserver/server.go:126 +0xaf
github.com/miekg/dns.HandlerFunc.ServeDNS(0xc000529270, 0x206dd00, 0xc00009e180, 0xc0005ae000)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:37 +0x44
github.com/miekg/dns.(*Server).serveDNS(0xc000286c60, 0xc000282400, 0x34, 0x200, 0xc00009e180)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:609 +0x2f7
github.com/miekg/dns.(*Server).serveUDPPacket(0xc000286c60, 0xc0003b03b4, 0xc000282400, 0x34, 0x200, 0xc00000e320, 0xc000522080)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:549 +0xb2
created by github.com/miekg/dns.(*Server).serveUDP
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:479 +0x292
~~~

Also fix single typo in chaos_test.go
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Fix naming
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      04e532b2
  11. 06 Oct, 2020 1 commit
  13. 05 Oct, 2020 6 commits
  15. 01 Oct, 2020 4 commits
  17. 30 Sep, 2020 2 commits
  19. 29 Sep, 2020 2 commits
  21. 28 Sep, 2020 5 commits
  23. 25 Sep, 2020 5 commits