Signed-off-by: Miek Gieben <miek@miek.nl>

few changes before the 1.4.0 release.
Signed-off-by: Miek Gieben <miek@miek.nl>

Signed-off-by: Miek Gieben <miek@miek.nl>

Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>

Mechanical change: make -f Makefile.doc
Signed-off-by: Miek Gieben <miek@miek.nl>

From [Golang coding convention](https://github.com/golang/go/wiki/CodeReviewComments#error-strings)

Co-Authored-By: Nguyen Van Trung [trungnvfet@outlook.com](mailto:trungnvfet@outlook.com)
Signed-off-by: Nguyen Quang Huy [huynq0911@gmail.com](mailto:huynq0911@gmail.com)

Signed-off-by: vanduc95 <ducnv@vn.fujitsu.com>

Signed-off-by: Vu Cong Tuan <tuanvc@vn.fujitsu.com>

Ignore temporary files *~ when editting source codes with
emacs.

Co-Authored-By: Dao Cong Tien tiendc@vn.fujitsu.com
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>

Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>

* Fixing panic in case if there's no response

There could be a situation when there's no response after ServeDNS call. With the current implementation, this leads to panic.

* Add comment

Signed-off-by: Miek Gieben <miek@miek.nl>

Currently, the modified link is out of date. This patch aims to update
this link to the working one that user can access.
Co-Authored-By: Nguyen Phuong An <AnNP@vn.fujitsu.com>
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>

There is no need to do this at the top of the handler, move this
down into the function.
Signed-off-by: Miek Gieben <miek@miek.nl>

Automatically submitted.

Signed-off-by: darshanime <deathbullet@gmail.com>

Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>

Part of the changes in 2591 modifies the vendor directory
which should not be modified. `dep ensure` will change it back.

This fix reverts the change of
```
vendor/github.com/apache/thrift/lib/go/thrift/simple_json_protocol.go
```

in 2591.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

Although it is spelling mistakes, it might make an affects
while reading.
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>

Currently, there are some links that we access with **HTTP**, it is
redirected to **HTTPS** automatically. So this commit aims to
replace **http://...** by **https://...** for security.
Co-Authored-By: Nguyen Phuong An <AnNP@vn.fujitsu.com>
Signed-off-by: Kim Bao Long <longkb@vn.fujitsu.com>

Signed-off-by: Xiao An <hac@zju.edu.cn>

Signed-off-by: Miek Gieben <miek@miek.nl>

Although it is spelling mistakes, it might make an affects
while reading.
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>

Signed-off-by: Nguyen Phuong An <AnNP@vn.fujitsu.com>

Although it is spelling mistakes, it might make an affects
while reading.
Signed-off-by: Nguyen Hai Truong <truongnh@vn.fujitsu.com>

Guard the access of h.size as this is now a data race.

Fixes #2571
Signed-off-by: Miek Gieben <miek@miek.nl>

* Upgrade caddy to 0.11.2

Redo of #2505 (cherry-picked commit)
Signed-off-by: Miek Gieben <miek@miek.nl>

* .4 has been released
Signed-off-by: Miek Gieben <miek@miek.nl>

Reload didn't take proper care to protect the fields from use in
different goroutines. Add a mutex and add helpers for usage and
interval.
Signed-off-by: Miek Gieben <miek@miek.nl>

Automatically submitted.

TestLookupAutoPathErratic sometimes fail on TravisCI saying below

```
=== RUN   TestLookupAutoPathErratic
--- FAIL: TestLookupAutoPathErratic (8.30s)
    erratic_autopath_test.go:39: Test 0, failed to sent query: "read udp [::1]:39758->[::1]:56643: i/o timeout"
FAIL
```

The failure happens when Google replies slowly.
This PR changes to not use Google but run CoreDNS locally and proxy to the server.

---

Because the failure depends on Google, sometimes it happens frequently but sometimes it doesn't happen.
I hope following test help you reproduce it.

```
func TestLookupAutoPathErratic2(t *testing.T) {
	for i := 0; i < 200; i++ {
		TestLookupAutoPathErratic(t)
	}
}
```

or I can reproduce it by changing proxy to other DNS like 1.1.1.1 instead of 8.8.8.8 too

Imports should be sorted by Go coding convention

* Fix some typos

Corect some words for reading more easily

* Update NOERROR response code

NOERROR is a response code so I revert the typo checking for it

Signed-off-by: Nguyen Van Trung <trungnv@vn.fujitsu.com>

The [ADDRESS] field in the metrics plugin is not explained in a manner
that makes it immediately obvious, that what we are talking about here
is a listening address.