Skip to content

C
Coredns
Switch branch/tag
This project is mirrored from https://github.com/coredns/coredns.git. The repository failed to update .
Repository mirroring has been paused due to too many failed attempts, and can be resumed by a project maintainer.
Last successful update .
  1. 19 Oct, 2020 5 commits
  3. 16 Oct, 2020 2 commits
  5. 15 Oct, 2020 4 commits
    • Miek Gieben's avatar
      cache: do the msg copy right (#4207) · 268781d3
      Miek Gieben authored 
      Not sure why this is proving so difficult.. pointers are hard? [Was
tempted to rollback all tweaks here, but the original issue we're fixing
it too important to not have a proper fix].

But we need to make a copy of the message at the earliest point in the
handler because we are changing it (adding an opt rr). If we do this on
the original message (which is a pointer) we change it (obvs). When
undoing those changes we do work on a copy.

Re: testing. There isn't a explicit test for this, so I've added on to
the top-level test/ directory, which indeed makes the issue visible:

master:

~~~
go test -v -run=TestLookupCacheWithoutEdns
=== RUN   TestLookupCacheWithoutEdns
    cache_test.go:154: Expected no OPT RR, but got:
        ;; OPT PSEUDOSECTION:
        ; EDNS: version 0; flags: do; udp: 2048
--- FAIL: TestLookupCacheWithoutEdns (0.01s)
FAIL
~~~

This branch:

~~~
% go test -v -run=TestLookupCacheWithoutEdns
=== RUN   TestLookupCacheWithoutEdns
--- PASS: TestLookupCacheWithoutEdns (0.01s)
PASS
ok  	github.com/coredns/coredns/test	0.109s
~~~
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      268781d3
    • Miek Gieben's avatar
      reduce sleeps (#4205) · 6938dac2
      Miek Gieben authored 
      This reduces the amount of sleep time to speed up testing.

master:
PASS
ok  	github.com/coredns/coredns/test	42.088s
12,33s user 1,30s system 44,29s elapsed 30%CPU ()

this branch:
PASS
ok  	github.com/coredns/coredns/test	33.527s
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      6938dac2
    • John Belamaric's avatar
      Add #4171 in notes (#4204) · 269c0c5d
      John Belamaric authored
      269c0c5d
    • Miek Gieben's avatar
      notes: update with latest (#4203) · 2eb761cc
      Miek Gieben authored 
      * notes: final prep for tomorrow release

Update with latest, remove 'not released'.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* typo check
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      2eb761cc
  7. 14 Oct, 2020 4 commits
    • Miek Gieben's avatar
      deps: bump miekg/dns to new version (#4201) · 768307ef
      Miek Gieben authored 
      upgrade to latest and greatest
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      768307ef
    • Miek Gieben's avatar
      plugin/transfer: remove duplicate code (#4200) · 623d1e01
      Miek Gieben authored 
      Was running coredns-master on my servers and kept seeing:

~~~
okt 14 10:38:06.473281 deb coredns[30303]: [INFO] plugin/transfer: Outgoing incremental transfer for up to date zone "miek.nl." to 37.97.149.87 for 1602370680 SOA serial
okt 14 10:40:06.498512 deb coredns[30303]: [INFO] plugin/transfer: Outgoing incremental transfer for up to date zone "miek.nl." to 37.97.149.87 for 1602370680 SOA serial
okt 14 10:42:06.553747 deb coredns[30303]: [INFO] plugin/transfer: Outgoing incremental transfer for up to date zone "miek.nl." to 37.97.149.87 for 1602370680 SOA serial
~~~

and I'm like shouldn't that be noop transfer? And sure enough, a
duplicated code block in the transfer code that logs this, so the `noop`
line is never reached.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      623d1e01
    • Miek Gieben's avatar
      plugin/cache: fix removing OPT (#4190) · be09f473
      Miek Gieben authored 
      By checking state.Do() were are checking if the request had DO, but
we are _always_ adding Do now - do we need to save the DO from the
ORIGINAL request, which must be done in the ResponseWriter.

Also skip OPT records in filterDNSSEC as we can't set the TTL on those
records, this prevents writing a number to OPT's MBZ.

Note none of the tests have changed and still PASS. This is due to
the fact that CoreDNSServerAndPorts isn't a full server as we start in
main, it lacks the scrubwriter for instance. This is not bad per se, but
should be documented in the test code.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      be09f473
    • Miek Gieben's avatar
      notes: add dnstap PR (#4197) · 34dc59fc
      Miek Gieben authored 
      few notes that this API also changed.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      34dc59fc
  9. 13 Oct, 2020 3 commits
  11. 12 Oct, 2020 8 commits
  13. 08 Oct, 2020 1 commit
  15. 07 Oct, 2020 1 commit
    • Miek Gieben's avatar
      core: fix crash with no plugins (#4184) · 04e532b2
      Miek Gieben authored 
      * core: fix crash with no plugins

A Corefile that defines a zone without plugins crashes coredns with the
stack trace below. Change this to return a refused.

~~~ corefile
 example.org {
    whoami
    log
    cache
    debug
}

example.net {
}
~~~

Asking for anyhing in example.net does this. Add test that tests this.

~~~
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xa5e6a4]

goroutine 55 [running]:
github.com/coredns/coredns/core/dnsserver.(*Server).ServeDNS(0xc000438f60, 0x2059420, 0xc0005a4030, 0x206c0e0, 0xc000522140, 0xc0005ae000)
	/home/miek/src/github.com/coredns/coredns/core/dnsserver/server.go:247 +0x884
github.com/coredns/coredns/core/dnsserver.(*Server).ServePacket.func1(0x206dd00, 0xc00009e180, 0xc0005ae000)
	/home/miek/src/github.com/coredns/coredns/core/dnsserver/server.go:126 +0xaf
github.com/miekg/dns.HandlerFunc.ServeDNS(0xc000529270, 0x206dd00, 0xc00009e180, 0xc0005ae000)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:37 +0x44
github.com/miekg/dns.(*Server).serveDNS(0xc000286c60, 0xc000282400, 0x34, 0x200, 0xc00009e180)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:609 +0x2f7
github.com/miekg/dns.(*Server).serveUDPPacket(0xc000286c60, 0xc0003b03b4, 0xc000282400, 0x34, 0x200, 0xc00000e320, 0xc000522080)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:549 +0xb2
created by github.com/miekg/dns.(*Server).serveUDP
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:479 +0x292
~~~

Also fix single typo in chaos_test.go
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Fix naming
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      04e532b2
  17. 06 Oct, 2020 1 commit
  19. 05 Oct, 2020 6 commits
  21. 01 Oct, 2020 4 commits
  23. 30 Sep, 2020 1 commit