Skip to content

C
Coredns
Switch branch/tag
This project is mirrored from https://github.com/coredns/coredns.git. The repository failed to update .
Repository mirroring has been paused due to too many failed attempts, and can be resumed by a project maintainer.
Last successful update .
  1. 13 Oct, 2020 2 commits
    • coredns-auto-go-mod-tidy[bot]'s avatar
      auto make -f Makefile.doc · 5f5cc318
      coredns-auto-go-mod-tidy[bot] authored
      5f5cc318
    • Miek Gieben's avatar
      plugin/dnstap: various cleanups (#4179) · b3b8a7e4
      Miek Gieben authored 
      * plugin/dnstap: various cleanups

A recent issue made me look into this plugin, I suspect various other
cleanups (hopefully deletion of code) can be made as well

Remove identical functions ToClientQuery etc, and just use tap.Message
as the base type in plugin. Keep msg/ for a few helper functions that
may proof useful.

This remove the whole test directory as we will just check the things we
are interested in which gives much better feedback and keeps that code
closer together.

tapwr dir is also not needed, writer_test.go was just duplicating the
tests already done. This moves writer.go to the top directory.

Make the only user of dnstap, the forward plugin, use the newer code
also remove the test, a better test there would be a full e2e test to
see the correct thing happens.

Cleanup the Tapper interface and move it to dnstapio where it belongs,
remove higher level interfaces that are not used. This remove
dnstap.Tapper and dnstap.IORoutines.

Use the standard mechanism for getting access to a plugin and remove
shuffling the plugin into the context.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* use opts to get the correct proto
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Various fixes
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Remove bad addr test, as dnstap is only called from within coredns where these fields have been preparsed
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* dnstap: remove saving the error

all these fields have been preparsed, no need for dnstap to be pedantic
and check (and save!) this error again.

Simplifies it a bit more.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Update plugin/forward/dnstap.go
Co-authored-by: default avatarRuslan Drozhdzh <30860269+rdrozhdzh@users.noreply.github.com>

* Code review
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* add back in preferUDP
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* nit
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
Co-authored-by: default avatarRuslan Drozhdzh <30860269+rdrozhdzh@users.noreply.github.com>
      b3b8a7e4
  3. 12 Oct, 2020 8 commits
  5. 08 Oct, 2020 1 commit
  7. 07 Oct, 2020 1 commit
    • Miek Gieben's avatar
      core: fix crash with no plugins (#4184) · 04e532b2
      Miek Gieben authored 
      * core: fix crash with no plugins

A Corefile that defines a zone without plugins crashes coredns with the
stack trace below. Change this to return a refused.

~~~ corefile
 example.org {
    whoami
    log
    cache
    debug
}

example.net {
}
~~~

Asking for anyhing in example.net does this. Add test that tests this.

~~~
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xa5e6a4]

goroutine 55 [running]:
github.com/coredns/coredns/core/dnsserver.(*Server).ServeDNS(0xc000438f60, 0x2059420, 0xc0005a4030, 0x206c0e0, 0xc000522140, 0xc0005ae000)
	/home/miek/src/github.com/coredns/coredns/core/dnsserver/server.go:247 +0x884
github.com/coredns/coredns/core/dnsserver.(*Server).ServePacket.func1(0x206dd00, 0xc00009e180, 0xc0005ae000)
	/home/miek/src/github.com/coredns/coredns/core/dnsserver/server.go:126 +0xaf
github.com/miekg/dns.HandlerFunc.ServeDNS(0xc000529270, 0x206dd00, 0xc00009e180, 0xc0005ae000)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:37 +0x44
github.com/miekg/dns.(*Server).serveDNS(0xc000286c60, 0xc000282400, 0x34, 0x200, 0xc00009e180)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:609 +0x2f7
github.com/miekg/dns.(*Server).serveUDPPacket(0xc000286c60, 0xc0003b03b4, 0xc000282400, 0x34, 0x200, 0xc00000e320, 0xc000522080)
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:549 +0xb2
created by github.com/miekg/dns.(*Server).serveUDP
	/home/miek/go/pkg/mod/github.com/miekg/dns@v1.1.31/server.go:479 +0x292
~~~

Also fix single typo in chaos_test.go
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Fix naming
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      04e532b2
  9. 06 Oct, 2020 1 commit
  11. 05 Oct, 2020 6 commits
  13. 01 Oct, 2020 4 commits
  15. 30 Sep, 2020 2 commits
  17. 29 Sep, 2020 2 commits
  19. 28 Sep, 2020 5 commits
  21. 25 Sep, 2020 5 commits
  23. 22 Sep, 2020 1 commit
  25. 21 Sep, 2020 1 commit
  27. 18 Sep, 2020 1 commit