Skip to content

C
Coredns
Switch branch/tag
This project is mirrored from https://github.com/coredns/coredns.git. The repository failed to update .
Repository mirroring has been paused due to too many failed attempts, and can be resumed by a project maintainer.
Last successful update .
  1. 27 Feb, 2019 5 commits
  3. 26 Feb, 2019 1 commit
  5. 25 Feb, 2019 3 commits
  7. 24 Feb, 2019 2 commits
  9. 22 Feb, 2019 2 commits
  11. 21 Feb, 2019 6 commits
  13. 20 Feb, 2019 1 commit
  15. 19 Feb, 2019 1 commit
  17. 18 Feb, 2019 2 commits
  19. 17 Feb, 2019 9 commits
  21. 15 Feb, 2019 1 commit
  23. 13 Feb, 2019 2 commits
    • Anders Ingemann's avatar
      Adjust docs for [ADDRESS] in metrics plugin (#2555) · 008f9eb8
      Anders Ingemann authored 
      The [ADDRESS] field in the metrics plugin is not explained in a manner
that makes it immediately obvious, that what we are talking about here
is a listening address.
      008f9eb8
    • Thomas Mangin's avatar
      plugin/hosts provide more configuration flexibility (#2535) · 4b402e00
      Thomas Mangin authored 
      * plugin/hosts provide more configuration flexibility

This patch adds few features to the host plugin
 * no-reverse (both as first argument on the plugin line and inline)
   disable the automatic generation of reserve entries for hosts
 * ttl <duration> (inline only atm)
   allows to change the default ttl (default 5 minutes)
 * reload <duration> (inline only atm)
   allows to change the reloading interval (default 5s)

* plugin/hosts remove superfluous parameters to parse
      4b402e00
  25. 12 Feb, 2019 1 commit
    • Miek Gieben's avatar
      pkg/replace: make it more efficient. (#2544) · e47d8814
      Miek Gieben authored 
      * pkg/replace: make it more efficient.

Remove the map that is allocated on every write and make it more static,
but just defining a function that gets called for a label and returns
its value.

Remove the interface definition and just implement what is needed in our
case. Add benchmark test for replace as well.

Extend metadata test to test multiple values (pretty sure this didn't
work, but there wasn't a test for it, so can't be sure).

Update all callers to use it - concurrent use should be fine as we pass
everything by value.

Benchmarks in replacer:

new: BenchmarkReplacer-4   300000      4717 ns/op     240 B/op       8 allocs/op
old: BenchmarkReplacer-4   300000      4368 ns/op     384 B/op      11 allocs/op

Added benchmark function to the old code to test it.

~~~
func BenchmarkReplacer(b *testing.B) {
	w := dnstest.NewRecorder(&test.ResponseWriter{})
	r := new(dns.Msg)
	r.SetQuestion("example.org.", dns.TypeHINFO)
	r.MsgHdr.AuthenticatedData = true
	b.ResetTimer()
	b.ReportAllocs()
	repl := New(context.TODO(), r, w, "")
	for i := 0; i < b.N; i++ {
		repl.Replace("{type} {name} {size}")
	}
}
~~~

New code contains (of course a different one). The amount of ops is
more, which might be good to look at some more. For all the allocations
is seems it was quite performant.

This looks to be 50% faster, and there is less allocations in log
plugin:

old: BenchmarkLogged-4   	   20000	     70526 ns/op
new: BenchmarkLogged-4   	   30000	     57558 ns/op
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Stickler bot
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Improve test coverage
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* typo
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Add test for malformed log lines
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      e47d8814
  27. 11 Feb, 2019 2 commits
  29. 09 Feb, 2019 2 commits