* Add proto and client-ip trace tags
Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>

* Commit my own suggestion
Signed-off-by: Miek Gieben <miek@miek.nl>
Co-authored-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>

* typos fixed
* a cache fix
* update/finalize some other bits
Signed-off-by: Miek Gieben <miek@miek.nl>

The filtering of DNSSEC records in the cache plugin was not done
correctly. Also the change to introduced this bug didn't take into
account that the cache - by virtue of differentiating between DNSSEC and
no-DNSSEC - relied on not copying the data from the cache.

This change copies and then filters the data and factors the filtering
into a function that is used in two places (albeit with on ugly boolean
parameters to prevent copying things twice).

Add tests, do_test.go is moved to test/cache_test.go because the OPT
handing is done outside of the cache plugin. The core server re-attaches
the correct OPT when replying, so that makes for a better e2e test.

Added small unit test for filterRRslice and an explicit test that asks
for DNSSEC first and then plain, and vice versa to test cache behavior.

Fixes: #4146
Signed-off-by: Miek Gieben <miek@miek.nl>

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.34.22 to 1.34.32.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.34.22...v1.34.32)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.19.1 to 0.19.2.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.19.1...v0.19.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.13.0 to 0.14.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](https://github.com/prometheus/common/compare/v0.13.0...v0.14.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Signed-off-by: Miek Gieben <miek@miek.nl>

* Implement notifies for transfer plugin (#3972)

* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl>

* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl>

* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl>

* golint
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl>

* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl>

* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl>

* golint
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl>

* really fix test
Signed-off-by: Miek Gieben <miek@miek.nl>

* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl>

* Add transfer tests

copied and modified from #3452
Signed-off-by: Miek Gieben <miek@miek.nl>

* Test correct selection of plugin
Signed-off-by: Miek Gieben <miek@miek.nl>

* add upstream back in
Signed-off-by: Miek Gieben <miek@miek.nl>

* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl>

* fix test
Signed-off-by: Miek Gieben <miek@miek.nl>

* properly merge
Signed-off-by: Miek Gieben <miek@miek.nl>

* Remove plugin/kubernetes/setup_transfer_test.go
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Co-authored-by: Miek Gieben <miek@miek.nl>

* For caddy v1 in our org

This RP changes all imports for caddyserver/caddy to coredns/caddy. This
is the v1 code of caddy.

For the coredns/caddy repo the following changes have been made:

* anything not needed by us is deleted
* all `telemetry` stuff is deleted
* all its import paths are also changed to point to coredns/caddy
* the v1 branch has been moved to the master branch
* a v1.1.0 tag has been added to signal the latest release
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix imports
Signed-off-by: Miek Gieben <miek@miek.nl>

* Group coredns/caddy with out plugins
Signed-off-by: Miek Gieben <miek@miek.nl>

* remove this file
Signed-off-by: Miek Gieben <miek@miek.nl>

* Relax import ordering

github.com/coredns is now also a coredns dep, this makes
github.com/coredns/caddy fit more natural in the list.
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix final import
Signed-off-by: Miek Gieben <miek@miek.nl>

This fixes some inefassign as report by Go report card:
https://goreportcard.com/report/github.com/coredns/corednsSigned-off-by: Miek Gieben <miek@miek.nl>

Set correct date on the release notes and add one more PR (for cache)
Signed-off-by: Miek Gieben <miek@miek.nl>

nit-picking PR, when using the name of the plugin make it cursive.
Signed-off-by: Miek Gieben <miek@miek.nl>

* cache: default to DNSSEC

This change does away with the DNS/DNSSEC distinction the cache
currently makes. Cache will always make coredns perform a DNSSEC query
and store that result. If a client just needs plain DNS, the DNSSEC
records are stripped from the response.

It should also be more memory efficient, because we store a reply once
and not one DNS and another for DNSSEC.

Fixes: #3836
Signed-off-by: Miek Gieben <miek@miek.nl>

* Change OPT RR when one is present in the msg.
Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix comment for isDNSSEC
Signed-off-by: Miek Gieben <miek@miek.nl>

* Update plugin/cache/handler.go
Co-authored-by: Chris O'Haver <cohaver@infoblox.com>

* Update plugin/cache/item.go
Co-authored-by: Chris O'Haver <cohaver@infoblox.com>

* Code review; fix comment for isDNSSEC
Signed-off-by: Miek Gieben <miek@miek.nl>

* Update doc and set AD to false

Set Authenticated Data to false when DNSSEC was not wanted. Also update
the readme with the new behavior.
Signed-off-by: Miek Gieben <miek@miek.nl>

* Update plugin/cache/handler.go
Co-authored-by: Chris O'Haver <cohaver@infoblox.com>
Co-authored-by: Chris O'Haver <cohaver@infoblox.com>

Updates the notes with latest PRs. I want the cache PR to be included in
this release as well, if possible.

Should release somewhere this week.
Signed-off-by: Miek Gieben <miek@miek.nl>

Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>

Signed-off-by: Ruslan Drozhdzh <rdrozhdzh@infoblox.com>

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.34.18 to 1.34.22.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.34.18...v1.34.22)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Signed-off-by: Ruslan Drozhdzh <rdrozhdzh@infoblox.com>

Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.19.0 to 0.19.1.
- [Release notes](https://github.com/kubernetes/client-go/releases)
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/kubernetes/client-go/compare/v0.19.0...v0.19.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Bumps [github.com/farsightsec/golang-framestream](https://github.com/farsightsec/golang-framestream) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/farsightsec/golang-framestream/releases)
- [Commits](https://github.com/farsightsec/golang-framestream/compare/v0.2.0...v0.3.0)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Bumps [github.com/Azure/go-autorest/autorest/azure/auth](https://github.com/Azure/go-autorest) from 0.5.1 to 0.5.2.
- [Release notes](https://github.com/Azure/go-autorest/releases)
- [Changelog](https://github.com/Azure/go-autorest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/Azure/go-autorest/compare/autorest/azure/auth/v0.5.1...autorest/azure/auth/v0.5.2)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

* plugin/trace: fix struct allignment

A 64 bit entity needs to be the first in a struct to make it work on 32
bit systems.

Fixes: #4111
Signed-off-by: Miek Gieben <miek@miek.nl>

* plugin/erratic does makes the same mistake
Signed-off-by: Miek Gieben <miek@miek.nl>

* plugin/forward: init ClientSessionCache in tls.Config

 - ClientSessionCache may speed up a TLS handshake in upcoming connections
   to the same TLS server
Signed-off-by: Ruslan Drozhdzh <rdrozhdzh@infoblox.com>

* add comment
Signed-off-by: Ruslan Drozhdzh <rdrozhdzh@infoblox.com>

Bumps [github.com/dnstap/golang-dnstap](https://github.com/dnstap/golang-dnstap) from 0.2.0 to 0.2.1.
- [Release notes](https://github.com/dnstap/golang-dnstap/releases)
- [Commits](https://github.com/dnstap/golang-dnstap/compare/v0.2.0...v0.2.1)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.34.13 to 1.34.18.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Changelog](https://github.com/aws/aws-sdk-go/blob/master/CHANGELOG.md)
- [Commits](https://github.com/aws/aws-sdk-go/compare/v1.34.13...v1.34.18)
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

The latest commit (e233f59e) on master branch introduced a trailing
whitespace and is causing Travis CI build to fail:
https://travis-ci.org/github/coredns/coredns/builds/722988413

This PR fixes the failing test.
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

Signed-off-by: Hu Shuai <hus.fnst@cn.fujitsu.com>

Stop the context so the refresh loop terminates on restart.

Fixes: #3815
Signed-off-by: Miek Gieben <miek@miek.nl>