Skip to content

C
Coredns
Switch branch/tag
This project is mirrored from https://github.com/coredns/coredns.git. The repository failed to update .
Repository mirroring has been paused due to too many failed attempts, and can be resumed by a project maintainer.
Last successful update .
  1. 25 Jul, 2019 1 commit
  3. 24 Jul, 2019 1 commit
    • Miek Gieben's avatar
      plugin/file: simplify locking (#3024) · eba020e6
      Miek Gieben authored 
      * plugin/file: simplify locking

Simplify the locking, remove the reloadMu and just piggyback on the
other lock for accessing content, which assumes things can be move
underneath.

Copy the Apex and Zone to new vars to make sure the pointer isn't
updated from under us.

The releadMu isn't need at all, the time.Ticker firing while we're
reading means we will just miss that tick and get it on the next go.

Add rrutil subpackage and put some more generic functions in there, that
are now used from file and the tree package. This removes some
duplication.

Rename additionalProcessing that didn't actually do that to
externalLookup, because that's what being done at some point.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>

* Update plugin/file/lookup.go
Co-Authored-By: default avatarMichael Grosser <development@stp-ip.net>
      eba020e6
  5. 23 Jul, 2019 2 commits
  7. 22 Jul, 2019 1 commit
  9. 21 Jul, 2019 1 commit
    • Miek Gieben's avatar
      plugin/file: New zone should have zero records (#3025) · 01e13c62
      Miek Gieben authored 
      After calling NewZone the number of records should be zero, but due to
how zone.All() was implemented so empty RRs would be added. This then
fails the == 0 check in xfr.go and put nil in the slice, this then
subsequently panics on the Len().

Fix this making All() smarter when adding records. Added little test to
enfore this.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      01e13c62
  11. 19 Jul, 2019 6 commits
  13. 18 Jul, 2019 2 commits
  15. 17 Jul, 2019 2 commits
    • Charlie Vieth's avatar
      replacer: evaluate format once and improve perf by ~3x (#3002) · a2af651e
      Charlie Vieth authored 
      * replacer: evaluate format once and improve perf by ~3x

This improves the performance of logging by almost 3x and reduces memory
usage by ~8x.

Benchmark results:

benchmark                                old ns/op     new ns/op     delta
BenchmarkReplacer-12                     644           324           -49.69%
BenchmarkReplacer_CommonLogFormat-12     4228          1471          -65.21%

benchmark                                old allocs     new allocs     delta
BenchmarkReplacer-12                     8              2              -75.00%
BenchmarkReplacer_CommonLogFormat-12     51             17             -66.67%

benchmark                                old bytes     new bytes     delta
BenchmarkReplacer-12                     240           48            -80.00%
BenchmarkReplacer_CommonLogFormat-12     3723          446           -88.02%

* replacer: code review comments

* bufPool: document why we use a pointer to a slice
* parseFormat: fix confusing comment
* TestParseFormat_Nodes: rename to TestParseFormatNodes

* replacer: use a value for bufPool instead of a pointer

* replacer: remove comment

* replacer: replace labels with knownLabels

The previous slice of label names is no longer needed.
      a2af651e
    • Charlie Vieth's avatar
      Fix log plugin benchmark and slightly improve performance (#3004) · 21e9c604
      Charlie Vieth authored 
      * log: use ioutil.Discard as write buffer in benchmark

Using a buffer gives unrealistic stats and consumes a large amount of
memory.

* log: lazily check if a msg should be logged

* log: improve variable name

Change 'ok' to the more descriptive 'shouldLog'.

* log: code comments: don't reuse variable
      21e9c604
  17. 16 Jul, 2019 1 commit
  19. 15 Jul, 2019 2 commits
  21. 14 Jul, 2019 1 commit
  23. 12 Jul, 2019 2 commits
  25. 11 Jul, 2019 3 commits
  27. 04 Jul, 2019 9 commits
  29. 03 Jul, 2019 4 commits
  31. 02 Jul, 2019 1 commit
  33. 30 Jun, 2019 1 commit
    • Miek Gieben's avatar
      plugin/file: load secondary zones lazily on startup (#2944) · 3a0c7c61
      Miek Gieben authored 
      This fixes a long standing bug:
fixes: #1609

Load secondary zones in a go-routine; this required another mutex to
protect some fields; I think those were needded anyway because a
transfer can also happen when we're running; we just didn't have a test
for that situation.

The test had to be changed to wait for the transfer to happen at this is
async now.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
      3a0c7c61