Some `go vet` cleanup (#869)

Some `go vet` cleanup
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

middleware/autopath/autopath_test.go

@@ -132,8 +132,6 @@ func nextHandler(mm map[string]int) test.Handler {
 		default:
 			panic("nextHandler: unhandled rcode")
 		}
-
-		return dns.RcodeServerFailure, nil
 	})
 }
 
@@ -159,7 +157,7 @@ func TestInSearchPath(t *testing.T) {
 	for i, tc := range tests {
 		got := a.FirstInSearchPath(tc.qname)
 		if got != tc.b {
-			t.Errorf("Test %d, got %d, expected %d", i, got, tc.b)
+			t.Errorf("Test %d, got %v, expected %v", i, got, tc.b)
 		}
 	}
 }

middleware/autopath/setup_test.go

@@ -14,7 +14,7 @@ import (
 func TestSetupAutoPath(t *testing.T) {
 	resolv, rm, err := test.TempFile(os.TempDir(), resolvConf)
 	if err != nil {
-		t.Fatalf("Could not create resolv.conf test file: %s", resolvConf, err)
+		t.Fatalf("Could not create resolv.conf test file %s: %s", resolvConf, err)
 	}
 	defer rm()
 

middleware/pkg/dnsutil/zone_test.go

@@ -24,7 +24,7 @@ func TestTrimZone(t *testing.T) {
 	for i, tc := range tests {
 		got, err := TrimZone(dns.Fqdn(tc.qname), dns.Fqdn(tc.zone))
 		if tc.err != nil && err == nil {
-			t.Errorf("Test %d, expected error got nil")
+			t.Errorf("Test %d, expected error got nil", i)
 			continue
 		}
 		if tc.err == nil && err != nil {