return standardized text for ready and health endpoint (#3195)

plugin/health/health.go

@@ -42,7 +42,7 @@ func (h *health) OnStartup() error {
 	h.mux.HandleFunc("/health", func(w http.ResponseWriter, r *http.Request) {
 		// We're always healthy.
 		w.WriteHeader(http.StatusOK)
-		io.WriteString(w, "OK")
+		io.WriteString(w, http.StatusText(http.StatusOK))
 		return
 	})
 

plugin/health/health_test.go

@@ -31,7 +31,7 @@ func TestHealth(t *testing.T) {
 	}
 	response.Body.Close()
 
-	if string(content) != "OK" {
+	if string(content) != http.StatusText(http.StatusOK) {
 		t.Errorf("Invalid response body: expecting 'OK', got '%s'", string(content))
 	}
 }

plugin/ready/ready.go

@@ -45,7 +45,7 @@ func (rd *ready) onStartup() error {
 		ok, todo := plugins.Ready()
 		if ok {
 			w.WriteHeader(http.StatusOK)
-			io.WriteString(w, "OK")
+			io.WriteString(w,  http.StatusText(http.StatusOK))
 			return
 		}
 		log.Infof("Still waiting on: %q", todo)

test/reload_test.go

@@ -110,7 +110,7 @@ func TestReloadMetricsHealth(t *testing.T) {
 	}
 	ok, _ := ioutil.ReadAll(resp.Body)
 	resp.Body.Close()
-	if string(ok) != "OK" {
+	if string(ok) != http.StatusText(http.StatusOK) {
 		t.Errorf("Failed to receive OK, got %s", ok)
 	}