Commit 8faca268 authored by Miek Gieben's avatar Miek Gieben Committed by GitHub

plugin/bind: tweak error messages (#4532)

When the interface doesn't exist you get:

plugin/bind: not a valid IP address: eth0

Fix the wording that this can also be interface name. Also %q the
argument in the error mesg.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
parent deb09c89
......@@ -33,7 +33,7 @@ func setup(c *caddy.Controller) error {
isIface = true
addrs, err := iface.Addrs()
if err != nil {
return plugin.Error("bind", fmt.Errorf("failed to get the IP(s) of the interface: %s", arg))
return plugin.Error("bind", fmt.Errorf("failed to get the IP addresses of the interface: %q", arg))
}
for _, addr := range addrs {
if ipnet, ok := addr.(*net.IPNet); ok {
......@@ -46,7 +46,7 @@ func setup(c *caddy.Controller) error {
}
if !isIface {
if net.ParseIP(arg) == nil {
return plugin.Error("bind", fmt.Errorf("not a valid IP address: %s", arg))
return plugin.Error("bind", fmt.Errorf("not a valid IP address or interface name: %q", arg))
}
all = append(all, arg)
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment