Skip to content

C
Coredns
Commit 86475927 authored by Zou Nengren's avatar Zou Nengren Committed by GitHub
Browse files
Options

format and add newline (#3969) 

Signed-off-by: default avatarzounengren <zounengren@cmss.chinamobile.com>
parent f4a1a0fe
Hide whitespace changes
Inline Side-by-side
Showing with 37 additions and 30 deletions
.travis.yml
View file @ 86475927
......@@ -27,6 +27,7 @@ env:
- TEST_TYPE=integration
- TEST_TYPE=core
- TEST_TYPE=plugin
- TEST_TYPE=fmt
# - TEST_TYPE=fuzzit FUZZIT_TYPE=local-regression
# - TEST_TYPE=fuzzit FUZZIT_TYPE=fuzzing
......
Makefile
View file @ 86475927
......@@ -28,6 +28,9 @@ endif
ifeq ($(TEST_TYPE),integration)
( cd test; go test -race ./... )
endif
ifeq ($(TEST_TYPE),fmt)
( echo "fmt"; gofmt -w -s . | grep ".*\.go"; if [ "$$?" = "0" ]; then exit 1; fi )
endif
ifeq ($(TEST_TYPE),plugin)
( cd plugin; go test -race ./... )
endif
......
plugin/dns64/dns64_test.go
View file @ 86475927
......@@ -164,7 +164,7 @@ func TestDNS64(t *testing.T) {
RecursionDesired: true,
Opcode: dns.OpcodeQuery,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
},
initResp: &dns.Msg{ //success, no answers
MsgHdr: dns.MsgHdr{
......@@ -174,7 +174,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Ns: []dns.RR{test.SOA("example.com. 70 IN SOA foo bar 1 1 1 1 1")},
},
aResp: &dns.Msg{
......@@ -185,7 +185,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeA, dns.ClassINET}},
Answer: []dns.RR{
test.A("example.com. 60 IN A 192.0.2.42"),
test.A("example.com. 5000 IN A 192.0.2.43"),
......@@ -200,7 +200,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Answer: []dns.RR{
test.AAAA("example.com. 60 IN AAAA 64:ff9b::192.0.2.42"),
// override RR ttl to SOA ttl, since it's lower
......@@ -217,7 +217,7 @@ func TestDNS64(t *testing.T) {
RecursionDesired: true,
Opcode: dns.OpcodeQuery,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
},
initResp: &dns.Msg{ //success, no answers
MsgHdr: dns.MsgHdr{
......@@ -227,7 +227,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Ns: []dns.RR{test.SOA("example.com. 3600 IN SOA foo bar 1 7200 900 1209600 86400")},
},
aResp: &dns.Msg{
......@@ -238,7 +238,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeA, dns.ClassINET}},
Ns: []dns.RR{test.SOA("example.com. 3600 IN SOA foo bar 1 7200 900 1209600 86400")},
},
......@@ -250,7 +250,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Ns: []dns.RR{test.SOA("example.com. 3600 IN SOA foo bar 1 7200 900 1209600 86400")},
Answer: []dns.RR{}, // just to make comparison happy
},
......@@ -264,7 +264,7 @@ func TestDNS64(t *testing.T) {
RecursionDesired: true,
Opcode: dns.OpcodeQuery,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
},
initResp: &dns.Msg{ // failure
MsgHdr: dns.MsgHdr{
......@@ -274,7 +274,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeRefused,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
},
aResp: &dns.Msg{
MsgHdr: dns.MsgHdr{
......@@ -284,7 +284,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeA, dns.ClassINET}},
Answer: []dns.RR{
test.A("example.com. 60 IN A 192.0.2.42"),
test.A("example.com. 5000 IN A 192.0.2.43"),
......@@ -299,7 +299,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Answer: []dns.RR{
test.AAAA("example.com. 60 IN AAAA 64:ff9b::192.0.2.42"),
test.AAAA("example.com. 600 IN AAAA 64:ff9b::192.0.2.43"),
......@@ -315,7 +315,7 @@ func TestDNS64(t *testing.T) {
RecursionDesired: true,
Opcode: dns.OpcodeQuery,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
},
initResp: &dns.Msg{ // failure
MsgHdr: dns.MsgHdr{
......@@ -325,7 +325,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeNameError,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Ns: []dns.RR{test.SOA("example.com. 3600 IN SOA foo bar 1 7200 900 1209600 86400")},
},
resp: &dns.Msg{
......@@ -336,7 +336,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeNameError,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Ns: []dns.RR{test.SOA("example.com. 3600 IN SOA foo bar 1 7200 900 1209600 86400")},
},
},
......@@ -349,7 +349,7 @@ func TestDNS64(t *testing.T) {
RecursionDesired: true,
Opcode: dns.OpcodeQuery,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
},
initResp: &dns.Msg{
......@@ -360,7 +360,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Answer: []dns.RR{
test.AAAA("example.com. 60 IN AAAA ::1"),
test.AAAA("example.com. 5000 IN AAAA ::2"),
......@@ -375,7 +375,7 @@ func TestDNS64(t *testing.T) {
Rcode: dns.RcodeSuccess,
Response: true,
},
Question: []dns.Question{dns.Question{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Question: []dns.Question{{"example.com.", dns.TypeAAAA, dns.ClassINET}},
Answer: []dns.RR{
test.AAAA("example.com. 60 IN AAAA ::1"),
test.AAAA("example.com. 5000 IN AAAA ::2"),
......
plugin/forward/forward.go
View file @ 86475927
......@@ -205,7 +205,7 @@ func (f *Forward) ForceTCP() bool { return f.opts.forceTCP }
func (f *Forward) PreferUDP() bool { return f.opts.preferUDP }
// List returns a set of proxies to be used for this client depending on the policy in f.
func (f *Forward) List() []*Proxy {return f.p.List(f.proxies)}
func (f *Forward) List() []*Proxy { return f.p.List(f.proxies) }
var (
// ErrNoHealthy means no healthy proxies left.
......
plugin/kubernetes/external_test.go
View file @ 86475927
......@@ -79,17 +79,17 @@ func TestExternal(t *testing.T) {
type external struct{}
func (external) HasSynced() bool { return true }
func (external) Run() {}
func (external) Stop() error { return nil }
func (external) EpIndexReverse(string) []*object.Endpoints { return nil }
func (external) SvcIndexReverse(string) []*object.Service { return nil }
func (external) Modified() int64 { return 0 }
func (external) EpIndex(s string) []*object.Endpoints { return nil }
func (external) EndpointsList() []*object.Endpoints { return nil }
func (external) HasSynced() bool { return true }
func (external) Run() {}
func (external) Stop() error { return nil }
func (external) EpIndexReverse(string) []*object.Endpoints { return nil }
func (external) SvcIndexReverse(string) []*object.Service { return nil }
func (external) Modified() int64 { return 0 }
func (external) EpIndex(s string) []*object.Endpoints { return nil }
func (external) EndpointsList() []*object.Endpoints { return nil }
func (external) GetNodeByName(ctx context.Context, name string) (*api.Node, error) { return nil, nil }
func (external) SvcIndex(s string) []*object.Service { return svcIndexExternal[s] }
func (external) PodIndex(string) []*object.Pod { return nil }
func (external) SvcIndex(s string) []*object.Service { return svcIndexExternal[s] }
func (external) PodIndex(string) []*object.Pod { return nil }
func (external) GetNamespaceByName(name string) (*api.Namespace, error) {
return &api.Namespace{
......
plugin/kubernetes/ns_test.go
View file @ 86475927
......@@ -103,7 +103,9 @@ func (APIConnTest) EpIndexReverse(ip string) []*object.Endpoints {
return eps
}
func (APIConnTest) GetNodeByName(ctx context.Context, name string) (*api.Node, error) { return &api.Node{}, nil }
func (APIConnTest) GetNodeByName(ctx context.Context, name string) (*api.Node, error) {
return &api.Node{}, nil
}
func (APIConnTest) GetNamespaceByName(name string) (*api.Namespace, error) {
return &api.Namespace{}, nil
}
......
plugin/whoami/whoami.go
View file @ 86475927
......@@ -13,6 +13,7 @@ import (
)
const name = "whoami"
// Whoami is a plugin that returns your IP address, port and the protocol used for connecting
// to CoreDNS.
type Whoami struct{}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment