Commit 7b8cf9df authored by Miek Gieben's avatar Miek Gieben Committed by GitHub

mw/health: call Shutdown on FinalShutdown (#1003)

Reloading caddy won't kill the health handler. Only on final shutdown
we stop the handler.

Currently when reloading CoreDNS with -SIGUSR1 the health handler stops
answering - there is a test for this but it doesn't capture whole
process reloading, sadly. This PR keeps the handler alive during reloads
and only stops on process shutdown.
parent 7e63bdbe
......@@ -47,7 +47,7 @@ func setup(c *caddy.Controller) error {
})
c.OnStartup(h.Startup)
c.OnShutdown(h.Shutdown)
c.OnFinalShutdown(h.Shutdown)
// Don't do AddMiddleware, as health is not *really* a middleware just a separate webserver running.
return nil
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment