Commit 5f900b86 authored by xuweiwei's avatar xuweiwei Committed by GitHub

cleanup some code (#4989)

Automatically submitted.
parent c707a4e7
...@@ -26,7 +26,7 @@ func isDNSSEC(r dns.RR) bool { ...@@ -26,7 +26,7 @@ func isDNSSEC(r dns.RR) bool {
// returned. // returned.
func filterRRSlice(rrs []dns.RR, ttl uint32, do, dup bool) []dns.RR { func filterRRSlice(rrs []dns.RR, ttl uint32, do, dup bool) []dns.RR {
j := 0 j := 0
rs := make([]dns.RR, len(rrs), len(rrs)) rs := make([]dns.RR, len(rrs))
for _, r := range rrs { for _, r := range rrs {
if !do && isDNSSEC(r) { if !do && isDNSSEC(r) {
continue continue
......
...@@ -31,9 +31,7 @@ func (c gcpClient) listRRSets(ctx context.Context, projectName, hostedZoneName s ...@@ -31,9 +31,7 @@ func (c gcpClient) listRRSets(ctx context.Context, projectName, hostedZoneName s
req := c.ResourceRecordSets.List(projectName, hostedZoneName) req := c.ResourceRecordSets.List(projectName, hostedZoneName)
var rs []*gcp.ResourceRecordSet var rs []*gcp.ResourceRecordSet
if err := req.Pages(ctx, func(page *gcp.ResourceRecordSetsListResponse) error { if err := req.Pages(ctx, func(page *gcp.ResourceRecordSetsListResponse) error {
for _, rr := range page.Rrsets { rs = append(rs, page.Rrsets...)
rs = append(rs, rr)
}
return nil return nil
}); err != nil { }); err != nil {
return nil, err return nil, err
......
...@@ -6,10 +6,7 @@ package kubernetes ...@@ -6,10 +6,7 @@ package kubernetes
// see namespaceExposed. // see namespaceExposed.
func (k *Kubernetes) filteredNamespaceExists(namespace string) bool { func (k *Kubernetes) filteredNamespaceExists(namespace string) bool {
_, err := k.APIConn.GetNamespaceByName(namespace) _, err := k.APIConn.GetNamespaceByName(namespace)
if err != nil { return err == nil
return false
}
return true
} }
// configuredNamespace returns true when the namespace is exposed through the plugin // configuredNamespace returns true when the namespace is exposed through the plugin
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment