Commit 48a8d6c7 authored by Carl-Magnus Björkell's avatar Carl-Magnus Björkell Committed by Miek Gieben

plugin/etcd: Remove unnecessary struct copy (#2497)

The `b` struct is just copying all the fields into a new one, to
check if it already existed in a set. This isn't needed as all the
fields are identical, and a small rearrangement of the code solves the
same problem without the copy.
parent 74c8bf25
...@@ -139,13 +139,12 @@ Nodes: ...@@ -139,13 +139,12 @@ Nodes:
if err := json.Unmarshal(n.Value, serv); err != nil { if err := json.Unmarshal(n.Value, serv); err != nil {
return nil, fmt.Errorf("%s: %s", n.Key, err.Error()) return nil, fmt.Errorf("%s: %s", n.Key, err.Error())
} }
b := msg.Service{Host: serv.Host, Port: serv.Port, Priority: serv.Priority, Weight: serv.Weight, Text: serv.Text, Key: string(n.Key)} serv.Key = string(n.Key)
if _, ok := bx[b]; ok { if _, ok := bx[*serv]; ok {
continue continue
} }
bx[b] = struct{}{} bx[*serv] = struct{}{}
serv.Key = string(n.Key)
serv.TTL = e.TTL(n, serv) serv.TTL = e.TTL(n, serv)
if serv.Priority == 0 { if serv.Priority == 0 {
serv.Priority = priority serv.Priority = priority
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment