Commit 458e7781 authored by Miek Gieben's avatar Miek Gieben Committed by GitHub

Revert "be sure to close connection after completion of xfr out. (#2866)" (#2872)

This reverts commit a657e1f6.
parent a657e1f6
...@@ -33,10 +33,7 @@ func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (in ...@@ -33,10 +33,7 @@ func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (in
ch := make(chan *dns.Envelope) ch := make(chan *dns.Envelope)
defer close(ch) defer close(ch)
tr := new(dns.Transfer) tr := new(dns.Transfer)
go func() { go tr.Out(w, r, ch)
tr.Out(w, r, ch)
w.Close()
}()
j, l := 0, 0 j, l := 0, 0
records = append(records, records[0]) // add closing SOA to the end records = append(records, records[0]) // add closing SOA to the end
...@@ -54,6 +51,7 @@ func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (in ...@@ -54,6 +51,7 @@ func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (in
} }
w.Hijack() w.Hijack()
// w.Close() // Client closes connection
return dns.RcodeSuccess, nil return dns.RcodeSuccess, nil
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment