Rename port to dns.port (#300)

Avoid clashing with other server types.

Rename port to dns.port (#300)
Avoid clashing with other server types.
440e9246 · Miek Gieben · GitHub · 9b5c9df3 · 440e9246
Commit 440e9246 authored Sep 25, 2016 by Miek Gieben Committed by GitHub Sep 25, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

core/dnsserver/register.go core/dnsserver/register.go +3 -1

No files found.
--- a/core/dnsserver/register.go
+++ b/core/dnsserver/register.go
@@ -14,8 +14,10 @@ import (

 const serverType = "dns"

+// Any flags defined here, need to be namespaced to the serverType other
+// wise they potentially clash with other server types.
 func init() {
-	flag.StringVar(&Port, "port", DefaultPort, "Default port")
+	flag.StringVar(&Port, serverType+".port", DefaultPort, "Default port")

 	caddy.RegisterServerType(serverType, caddy.ServerType{
 		Directives: func() []string { return directives },