Commit 37d06f38 authored by John Belamaric's avatar John Belamaric Committed by Miek Gieben

Warn if the hosts file is a directory (#1126)

parent 4276d29b
...@@ -50,7 +50,7 @@ func hostsParse(c *caddy.Controller) (Hosts, error) { ...@@ -50,7 +50,7 @@ func hostsParse(c *caddy.Controller) (Hosts, error) {
if !path.IsAbs(h.path) && config.Root != "" { if !path.IsAbs(h.path) && config.Root != "" {
h.path = path.Join(config.Root, h.path) h.path = path.Join(config.Root, h.path)
} }
_, err := os.Stat(h.path) s, err := os.Stat(h.path)
if err != nil { if err != nil {
if os.IsNotExist(err) { if os.IsNotExist(err) {
log.Printf("[WARNING] File does not exist: %s", h.path) log.Printf("[WARNING] File does not exist: %s", h.path)
...@@ -58,6 +58,9 @@ func hostsParse(c *caddy.Controller) (Hosts, error) { ...@@ -58,6 +58,9 @@ func hostsParse(c *caddy.Controller) (Hosts, error) {
return h, c.Errf("unable to access hosts file '%s': %v", h.path, err) return h, c.Errf("unable to access hosts file '%s': %v", h.path, err)
} }
} }
if s != nil && s.IsDir() {
log.Printf("[WARNING] hosts file %q is a directory", h.path)
}
} }
origins := make([]string, len(c.ServerBlockKeys)) origins := make([]string, len(c.ServerBlockKeys))
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment