• Miek Gieben's avatar
    Fix EDNS0 compliance (#2357) · fc667b98
    Miek Gieben authored
    * Fix EDNS0 compliance
    
    Do SizeAndDo in the server (ScrubWriter) and remove all uses of this
    from the plugins. Also *always* do it. This is to get into compliance
    for https://dnsflagday.net/.
    
    The pkg/edns0 now exports the EDNS0 options we understand; this is
    exported to allow plugins add things there. The *rewrite* plugin used
    this to add custom EDNS0 option codes that the server needs to
    understand.
    
    This also needs a new release of miekg/dns because it triggered a
    race-condition that was basicly there forever.
    
    See:
    * https://github.com/miekg/dns/issues/857
    * https://github.com/miekg/dns/pull/859
    
    Running a test instance and pointing the https://ednscomp.isc.org/ednscomp
    to it shows the tests are now fixed:
    
    ~~~
    EDNS Compliance Tester
    Checking: 'miek.nl' as at 2018-12-01T17:53:15Z
    
    miek.nl. @147.75.204.203 (drone.coredns.io.): dns=ok edns=ok edns1=ok edns@512=ok ednsopt=ok edns1opt=ok do=ok ednsflags=ok docookie=ok edns512tcp=ok optlist=ok
    miek.nl. @2604:1380:2002:a000::1 (drone.coredns.io.): dns=ok edns=ok edns1=ok edns@512=ok ednsopt=ok edns1opt=ok do=ok ednsflags=ok docookie=ok edns512tcp=ok optlist=ok
    
    All Ok
    Codes
    ok - test passed.
    ~~~
    Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
    Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
    
    * typos in comments
    Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
    fc667b98
request_test.go 7.19 KB