• Miek Gieben's avatar
    Default to upstream to self (#2436) · 9c16ed1d
    Miek Gieben authored
    * Default to upstream to self
    
    This is a backwards incompatible change.
    
    This is a massive (cleanup) PR where we default to resolving external
    names by the coredns process itself, instead of directly forwarding them
    to some upstream.
    
    This ignores any arguments `upstream` may have had and makes it depend
    on proxy/forward configuration in the Corefile. This allows resolved
    upstream names to be cached and we have better healthchecking of the
    upstreams. It also means there is only one way to resolve names, by
    either using the proxy or forward plugin.
    
    The proxy/forward lookup.go functions have been removed. This also
    lessen the dependency on proxy, meaning deprecating proxy will become
    easier. Some tests have been removed as well, or moved to the top-level
    test directory as they now require a full coredns process instead of
    just the plugin.
    
    For the etcd plugin, the entire StubZone resolving is *dropped*! This
    was a hacky (but working) solution to say the least. If someone cares
    deeply it can be brought back (maybe)?
    
    The pkg/upstream is now very small and almost does nothing. Also the
    New() function was changed to return a pointer to upstream.Upstream. It
    also returns only one parameter, so any stragglers using it will
    encounter a compile error.
    
    All documentation has been adapted. This affected the following plugins:
    * etcd
    * file
    * auto
    * secondary
    * federation
    * template
    * route53
    
    A followup PR will make any upstream directives with arguments an error,
    right now they are ignored.
    Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
    
    * Fix etcd build - probably still fails unit test
    Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
    
    * Slightly smarter lookup check in upstream
    Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
    
    * Compilez
    Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
    9c16ed1d
proxy_test.go 2.08 KB