"...Irrlicht/svn:/svn.code.sf.net/p/irrlicht/code/trunk@4237" did not exist on "b589323a49f95d717309c2f68dccdc64bc4c8204"
  • Miek Gieben's avatar
    Default to scrubbing replies in the server (#2012) · ba1efee4
    Miek Gieben authored
    Every plugin needs to deal with EDNS0 and should call Scrub to make a
    message fit the client's buffer. Move this functionality into the server
    and wrapping the ResponseWriter into a ScrubWriter that handles these
    bits for us. Result:
    
    Less code and faster, because multiple chained plugins could all be
    calling scrub and SizeAndDo - now there is just one place.
    
    Most tests in file/* and dnssec/* needed adjusting because in those unit
    tests you don't see OPT RRs anymore. The DNSSEC signer was also looking
    at the returned OPT RR to see if it needed to sign - as those are now
    added by the server (and thus later), this needed to change slightly.
    
    Scrub itself still exist (for backward compat reasons), but has been
    made a noop. Scrub has been renamed to scrub as it should not be used by
    external plugins.
    
    Fixes: #2010
    Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
    ba1efee4
handler_test.go 5.68 KB