• Miek Gieben's avatar
    plugin/forward using pkg/up (#1493) · 16504234
    Miek Gieben authored
    * plugin/forward: on demand healtchecking
    
    Only start doing health checks when we encouner an error (any error).
    This uses the new pluing/pkg/up package to abstract away the actual
    checking. This reduces the LOC quite a bit; does need more testing, unit
    testing and tcpdumping a bit.
    
    * fix tests
    
    * Fix readme
    
    * Use pkg/up for healthchecks
    
    * remove unused channel
    
    * more cleanups
    
    * update readme
    
    * * Again do go generate and go build; still referencing the wrong forward
      repo? Anyway fixed.
    * Use pkg/up for doing the healtchecks to cut back on unwanted queries
      * Change up.Func to return an error instead of a boolean.
      * Drop the string target argument as it doesn't make sense.
    * Add healthcheck test on failing to get an upstream answer.
    
    TODO(miek): double check Forward and Lookup and how they interact with
    HC, and if we correctly call close() on those
    
    * actual test
    
    * Tests here
    
    * more tests
    
    * try getting rid of host
    
    * Get rid of the host indirection
    
    * Finish removing hosts
    
    * moar testing
    
    * import fmt
    
    * field is not used
    
    * docs
    
    * move some stuff
    
    * bring back health_check
    
    * maxfails=0 test
    
    * git and merging, bah
    
    * review
    16504234
forward_test.go 1.15 KB