attack_all_target_check()

check at EVENT_BE_BATTLE_TARGET and begining of damage calculation.

field.cpp

@@ -1720,9 +1720,10 @@ int32 field::get_attack_target(card* pcard, card_vector* v, uint8 chain_attack)
 		dir = false;
 	else{
 		// effects with target limit
-		// The system only check the general case (never attacked player), and the script should check specific condition.
+		// The system only check the general case (never attacked player) and approximate solution
 		if((peffect = pcard->is_affected_by_effect(EFFECT_ATTACK_ALL))
-				&& pcard->announced_cards.find(0) == pcard->announced_cards.end() && pcard->battled_cards.find(0) == pcard->battled_cards.end()) {
+				&& pcard->announced_cards.find(0) == pcard->announced_cards.end() && pcard->battled_cards.find(0) == pcard->battled_cards.end()
+				&& pcard->attack_all_target) {
 			for(auto cit = pv->begin(); cit != pv->end(); ++cit) {
 				atarget = *cit;
 				if(!atarget)

libduel.cpp

@@ -1211,6 +1211,7 @@ int32 scriptlib::duel_change_attack_target(lua_State *L) {
 				pduel->game_field->core.opp_mzone[i] = 0;
 		}
 		pduel->game_field->check_card_counter(pduel->game_field->core.attacker, 5, pduel->game_field->infos.turn_player);
+		pduel->game_field->attack_all_target_check();
 		if(target) {
 			pduel->game_field->raise_single_event(target, 0, EVENT_BE_BATTLE_TARGET, 0, REASON_REPLACE, 0, 1 - turnp, 0);
 			pduel->game_field->raise_event(target, EVENT_BE_BATTLE_TARGET, 0, REASON_REPLACE, 0, 1 - turnp, 0);

processor.cpp

@@ -2999,6 +2999,7 @@ int32 field::process_battle_command(uint16 step) {
 	case 7: {
 		bool evt = false;
 		check_card_counter(core.attacker, 5, infos.turn_player);
+		attack_all_target_check();
 		pduel->write_buffer8(MSG_ATTACK);
 		pduel->write_buffer32(core.attacker->get_info_location());
 		if(core.attack_target) {
@@ -3075,11 +3076,8 @@ int32 field::process_battle_command(uint16 step) {
 			else 
 				core.units.begin()->arg2 = 0;
 			reset_phase(PHASE_DAMAGE);
-			if(core.attacker->fieldid_r == afid) {
-				if(!atk_disabled) {
-					core.attacker->attacked_cards.addcard(core.attack_target);
-				}
-				attack_all_target_check();
+			if(core.attacker->fieldid_r == afid && !atk_disabled) {
+				core.attacker->attacked_cards.addcard(core.attack_target);
 			}
 			if(!peffect->value) {
 				infos.phase = PHASE_BATTLE;
@@ -3094,11 +3092,8 @@ int32 field::process_battle_command(uint16 step) {
 		if(atk_disabled || !core.attacker->is_capable_attack() || core.attacker->is_status(STATUS_ATTACK_CANCELED)
 		        || core.attacker->current.controler != acon || core.attacker->fieldid_r != afid) {
 			core.chain_attack = FALSE;
-			if(core.attacker->fieldid_r == afid) {
-				attack_all_target_check();
-				if(!atk_disabled) {
-					core.attacker->attacked_cards.addcard(core.attack_target);
-				}
+			if(core.attacker->fieldid_r == afid && !atk_disabled) {
+				core.attacker->attacked_cards.addcard(core.attack_target);
 			}
 			core.units.begin()->step = -1;
 			reset_phase(PHASE_DAMAGE);
@@ -3113,7 +3108,6 @@ int32 field::process_battle_command(uint16 step) {
 			rollback = true;
 		// go to damage step
 		if(!rollback) {
-			attack_all_target_check();
 			core.attacker->attacked_cards.addcard(core.attack_target);
 			core.units.begin()->step = 19;
 			adjust_all();
@@ -3122,7 +3116,6 @@ int32 field::process_battle_command(uint16 step) {
 		// attack canceled
 		if(!core.select_cards.size() && !core.attacker->operation_param) {
 			core.chain_attack = FALSE;
-			attack_all_target_check();
 			core.units.begin()->step = -1;
 			reset_phase(PHASE_DAMAGE);
 			adjust_all();
@@ -3144,7 +3137,6 @@ int32 field::process_battle_command(uint16 step) {
 			return FALSE;
 		}
 		core.chain_attack = FALSE;
-		attack_all_target_check();
 		core.units.begin()->step = -1;
 		reset_phase(PHASE_DAMAGE);
 		adjust_all();
@@ -3627,6 +3619,7 @@ int32 field::process_damage_step(uint16 step) {
 			return FALSE;
 		}
 		check_card_counter(core.attacker, 5, infos.turn_player);
+		attack_all_target_check();
 		pduel->write_buffer8(MSG_ATTACK);
 		pduel->write_buffer32(core.attacker->get_info_location());
 		pduel->write_buffer32(core.attack_target->get_info_location());