Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
O
oh-my-fish
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Packages
Packages
List
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issues
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nanahira
oh-my-fish
Commits
30f35666
Commit
30f35666
authored
Jan 30, 2015
by
Bruno
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #357 from bpinto/contributing_guidelines
contributing guidelines
parents
fdcf0ab2
3421d685
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
37 additions
and
0 deletions
+37
-0
CONTRIBUTING.md
CONTRIBUTING.md
+37
-0
No files found.
CONTRIBUTING.md
0 → 100644
View file @
30f35666
# Contributing
We love pull requests. Here's a quick guide.
Fork and make your change. Make sure the tests pass:
./script/run-tests.fish -v
Push to your fork and
[
submit a pull request
][
pr
]
.
[
pr
]:
https://github.com/bpinto/oh-my-fish/compare/
At this point you're waiting on us. We usually comment on pull requests
within a few hours. We may suggest some changes or improvements or alternatives.
Some things that will increase the chance that your pull request is accepted:
*
Write tests.
*
Follow our
[
style guide
][
style
]
.
*
Write a
[
good commit message
][
commit
]
.
## Style Guide
*
Indentation should follow the "2-space convention".
*
Keep line length to a maximum of 100 characters.
### Plugins
If your plugin is complex, make sure to include tests, we suggest using
[
fish-spec
](
fish-spec
)
.
### Themes
Make sure to include a screenshot in your pull request. A nifty way is too post a comment with the image and link directly to it.
[
fish-spec
]:
https://github.com/bpinto/oh-my-fish/tree/master/plugins/fish-spec
[
commit
]:
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
[
style
]:
#style-guide
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment