Merge pull request #84 from parente/earlier-user

Create jovyan user before conda install

minimal-notebook/Dockerfile

@@ -38,31 +38,36 @@ ENV SHELL /bin/bash
 ENV NB_USER jovyan
 ENV NB_UID 1000
 
-# Install conda
-RUN mkdir -p $CONDA_DIR && \
-    echo export PATH=$CONDA_DIR/bin:'$PATH' > /etc/profile.d/conda.sh && \
+# Create jovyan user with UID=1000 and in the 'users' group
+RUN useradd -m -s /bin/bash -N -u $NB_UID $NB_USER && \
+    mkdir -p /opt/conda && \
+    chown jovyan /opt/conda
+
+USER jovyan
+
+# Setup jovyan home directory
+RUN mkdir /home/$NB_USER/work && \
+    mkdir /home/$NB_USER/.jupyter && \
+    mkdir /home/$NB_USER/.local
+
+# Install conda as jovyan
+RUN cd /tmp && \
+    mkdir -p $CONDA_DIR && \
     wget --quiet https://repo.continuum.io/miniconda/Miniconda3-3.9.1-Linux-x86_64.sh && \
     echo "6c6b44acdd0bc4229377ee10d52c8ac6160c336d9cdd669db7371aa9344e1ac3 *Miniconda3-3.9.1-Linux-x86_64.sh" | sha256sum -c - && \
-    /bin/bash /Miniconda3-3.9.1-Linux-x86_64.sh -f -b -p $CONDA_DIR && \
+    /bin/bash Miniconda3-3.9.1-Linux-x86_64.sh -f -b -p $CONDA_DIR && \
     rm Miniconda3-3.9.1-Linux-x86_64.sh && \
     $CONDA_DIR/bin/conda install --yes conda==3.14.1
 
-# Install Jupyter notebook
+# Install Jupyter notebook as jovyan
 RUN conda install --yes \
     'notebook=4.0*' \
     terminado \
     && conda clean -yt
 
-# Create jovyan user with UID=1000 and in the 'users' group
-# Grant ownership over the conda dir and home dir, but stick the group as root.
-RUN useradd -m -s /bin/bash -N -u $NB_UID $NB_USER && \
-    mkdir /home/$NB_USER/work && \
-    mkdir /home/$NB_USER/.jupyter && \
-    mkdir /home/$NB_USER/.local && \
-    chown -R $NB_USER:users $CONDA_DIR && \
-    chown -R $NB_USER:users /home/$NB_USER
+USER root
 
-# Configure container startup
+# Configure container startup as root
 EXPOSE 8888
 WORKDIR /home/$NB_USER/work
 ENTRYPOINT ["tini", "--"]
@@ -71,4 +76,7 @@ CMD ["start-notebook.sh"]
 # Add local files as late as possible to avoid cache busting
 COPY start-notebook.sh /usr/local/bin/
 COPY jupyter_notebook_config.py /home/$NB_USER/.jupyter/
-RUN chown -R $NB_USER:users /home/$NB_USER/.jupyter
+RUN chown -R $NB_USER:users /home/$NB_USER/.jupyter
\ No newline at end of file
+
+# Stay as root so that the start-notebook.sh command can properly change 
+# jovyan to a configurable NB_UID and grant sudo if requested