Commit f39bbe2f authored by znakeeye's avatar znakeeye Committed by David Reid

Revert "Fix for NDK issue 360. dlclose() skipped pre-API 28. This fixes weird...

Revert "Fix for NDK issue 360. dlclose() skipped pre-API 28. This fixes weird crashes during uninit."

This reverts commit 14f698fcf289261946aefd0000dc5989062cf423.
parent 79bb4d7a
...@@ -38472,18 +38472,6 @@ static ma_result ma_device_get_info__aaudio(ma_device* pDevice, ma_device_type t ...@@ -38472,18 +38472,6 @@ static ma_result ma_device_get_info__aaudio(ma_device* pDevice, ma_device_type t
return MA_SUCCESS; return MA_SUCCESS;
} }
static void ma_close_library__aaudio(ma_context* pContext)
{
MA_ASSERT(pContext != NULL);
/* Hack for Android bug (see https://github.com/android/ndk/issues/360). Calling dlclose() pre-API 28 may segfault. */
if (ma_android_sdk_version() >= 28) {
ma_dlclose(ma_context_get_log(pContext), pContext->aaudio.hAAudio);
}
pContext->aaudio.hAAudio = NULL;
}
static ma_result ma_context_uninit__aaudio(ma_context* pContext) static ma_result ma_context_uninit__aaudio(ma_context* pContext)
{ {
...@@ -38491,7 +38479,9 @@ static ma_result ma_context_uninit__aaudio(ma_context* pContext) ...@@ -38491,7 +38479,9 @@ static ma_result ma_context_uninit__aaudio(ma_context* pContext)
MA_ASSERT(pContext->backend == ma_backend_aaudio); MA_ASSERT(pContext->backend == ma_backend_aaudio);
ma_device_job_thread_uninit(&pContext->aaudio.jobThread, &pContext->allocationCallbacks); ma_device_job_thread_uninit(&pContext->aaudio.jobThread, &pContext->allocationCallbacks);
ma_close_library__aaudio(pContext);
ma_dlclose(ma_context_get_log(pContext), pContext->aaudio.hAAudio);
pContext->aaudio.hAAudio = NULL;
return MA_SUCCESS; return MA_SUCCESS;
} }
...@@ -38599,7 +38589,8 @@ static ma_result ma_context_init__aaudio(ma_context* pContext, const ma_context_ ...@@ -38599,7 +38589,8 @@ static ma_result ma_context_init__aaudio(ma_context* pContext, const ma_context_
result = ma_device_job_thread_init(&jobThreadConfig, &pContext->allocationCallbacks, &pContext->aaudio.jobThread); result = ma_device_job_thread_init(&jobThreadConfig, &pContext->allocationCallbacks, &pContext->aaudio.jobThread);
if (result != MA_SUCCESS) { if (result != MA_SUCCESS) {
ma_close_library__aaudio(pContext); ma_dlclose(ma_context_get_log(pContext), pContext->aaudio.hAAudio);
pContext->aaudio.hAAudio = NULL;
return result; return result;
} }
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment