Commit 1cf4d1c8 authored by twanvl's avatar twanvl

the new pack system now actually works (yay!)

parent 41b7ae72
This diff is collapsed.
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
#include <script/scriptable.hpp> #include <script/scriptable.hpp>
#include <boost/random/mersenne_twister.hpp> #include <boost/random/mersenne_twister.hpp>
#define USE_NEW_PACK_SYSTEM 0 #define USE_NEW_PACK_SYSTEM 1
#if !USE_NEW_PACK_SYSTEM #if !USE_NEW_PACK_SYSTEM
// =================================================================================================== OLD // =================================================================================================== OLD
...@@ -103,20 +103,29 @@ class PackItemCache { ...@@ -103,20 +103,29 @@ class PackItemCache {
}; };
#else #else
// =================================================================================================== NEW // =================================================================================================== NEW
DECLARE_POINTER_TYPE(PackType);
DECLARE_POINTER_TYPE(PackItem); DECLARE_POINTER_TYPE(PackItem);
DECLARE_POINTER_TYPE(PackInstance);
DECLARE_POINTER_TYPE(Card); DECLARE_POINTER_TYPE(Card);
class Set; DECLARE_POINTER_TYPE(Set);
class PackGenerator;
// ----------------------------------------------------------------------------- : PackType // ----------------------------------------------------------------------------- : PackType
enum OneMany enum PackSelectType
{ SELECT_ONE_OR_EMPTY { SELECT_AUTO
, SELECT_ONE
, SELECT_FIRST
, SELECT_ALL , SELECT_ALL
, SELECT_REPLACE
, SELECT_NO_REPLACE
, SELECT_CYCLIC
, SELECT_PROPORTIONAL
, SELECT_NONEMPTY
, SELECT_FIRST
}; };
/// A card pack description for playtesting /// A card pack description for playtesting
...@@ -128,8 +137,7 @@ class PackType : public IntrusivePtrBase<PackType> { ...@@ -128,8 +137,7 @@ class PackType : public IntrusivePtrBase<PackType> {
Scriptable<bool> enabled; ///< Is this pack enabled? Scriptable<bool> enabled; ///< Is this pack enabled?
bool selectable; ///< Is this pack listed in the UI? bool selectable; ///< Is this pack listed in the UI?
bool summary; ///< Should the total be listed for this type? bool summary; ///< Should the total be listed for this type?
OneMany select; ///< Select one or many? PackSelectType select; ///< What cards/items to select
OptionalScript cards; ///< Script to select this type of cards (there are no items)
OptionalScript filter; ///< Filter to select this type of cards OptionalScript filter; ///< Filter to select this type of cards
vector<PackItemP> items; ///< Subpacks in this pack vector<PackItemP> items; ///< Subpacks in this pack
...@@ -140,24 +148,14 @@ class PackType : public IntrusivePtrBase<PackType> { ...@@ -140,24 +148,14 @@ class PackType : public IntrusivePtrBase<PackType> {
DECLARE_REFLECTION(); DECLARE_REFLECTION();
}; };
// ----------------------------------------------------------------------------- : PackItem
enum PackSelectType
{ PACK_REF_INHERIT
, PACK_REF_REPLACE
, PACK_REF_NO_REPLACE
, PACK_REF_CYCLIC
};
/// An item in a PackType /// An item in a PackType
class PackItem : public IntrusivePtrBase<PackItem> { class PackItem : public IntrusivePtrBase<PackItem> {
public: public:
PackItem(); PackItem();
String pack; ///< Name of the pack to select cards from String name; ///< Name of the pack to select cards from
Scriptable<int> amount; ///< Number of cards of this type Scriptable<int> amount; ///< Number of cards of this type
Scriptable<double> weight; ///< Relative probability of picking this item Scriptable<double> probability; ///< Relative probability of picking this item
PackSelectType type;
/// Update scripts, returns true if there is a change /// Update scripts, returns true if there is a change
bool update(Context& ctx); bool update(Context& ctx);
...@@ -166,86 +164,65 @@ class PackItem : public IntrusivePtrBase<PackItem> { ...@@ -166,86 +164,65 @@ class PackItem : public IntrusivePtrBase<PackItem> {
DECLARE_REFLECTION(); DECLARE_REFLECTION();
}; };
// ----------------------------------------------------------------------------- : Generating / counting
// --------------------------------------------------- : PackItemCache // ----------------------------------------------------------------------------- : Generating / counting
class PackItemCache { // A PackType that is instantiated for a particular Set,
// i.e. we now know the actual cards
class PackInstance : public IntrusivePtrBase<PackInstance> {
public: public:
PackItemCache(Set& set) : set(set) {} PackInstance(const PackType& pack_type, PackGenerator& parent);
/// Look up a pack type by name /// Expect to pick this many copies from this pack, updates expected_copies
const PackType& pack(const String& name); void expect_copy(double copies = 1);
/// Request some copies of this pack
void request_copy(size_t copies = 1);
protected: /// Generate cards if depth == at_depth
Set& set; /** Some cards are (optionally) added to out and card_copies
* And also the copies of referenced items might be incremented
*
* Resets the count of this instance to 0 */
void generate(vector<CardP>* out);
/// The cards for a given PackItem inline int get_depth() const { return depth; }
ScriptValueP cardsFor(const ScriptValueP& cards_script); inline bool has_cards() const { return !cards.empty(); }
inline size_t get_card_copies() const { return card_copies; }
inline double get_expected_copies() const { return expected_copies; }
private: private:
/// Lookup PackTypes by name const PackType& pack_type;
//%% PackGenerator& parent;
/// Cards for each PackType int depth; //< 0 = no items, otherwise 1+max depth of items refered to
map<ScriptValueP,ScriptValueP> item_cards; vector<CardP> cards; //< All cards that pass the filter
size_t count; //< Total number of non-empty cards/items
double total_probability; //< Sum of item and card probabilities
size_t requested_copies; //< The requested number of copies of this pack
size_t card_copies; //< The number of cards that were chosen to come from this pack
double expected_copies;
}; };
// --------------------------------------------------- : Counting expected cards class PackGenerator {
/// Class for determining the *expected* number of cards from each type
class PackItemCounter : PackItemCache {
public: public:
PackItemCounter(Set& set, map<const PackType*,double>& counts) /// Reset the generator, possibly switching the set or reseeding
: PackItemCache(set), counts(counts) void reset(const SetP& set, int seed);
{}
/// Add a number of copies of the PackType to the counts, recurse into child items /// Find the PackInstance for the PackType with the given name
void addCountRecursive(const PackType& pack, double copies); PackInstance& get(const String& name);
void addCountRecursive(const PackItem& item, double copies); PackInstance& get(const PackTypeP& type);
/// The probability that the given pack is non-empty /// Generate all cards, resets copies
double probabilityNonEmpty(const PackType& pack); void generate(vector<CardP>& out);
double probabilityNonEmpty(const PackItem& item); /// Update all card_copies counters, resets copies
void update_card_counts();
/// The counts will be stored here
map<const PackType*,double>& counts;
// only for PackInstance
SetP set; ///< The set
boost::mt19937 gen; ///< Random generator
private: private:
/// The probability that a pack type is empty (cache) /// Details for each PackType
//%map<const PackItem*,double> probability_empty; map<String,PackInstanceP> instances;
}; int max_depth;
// --------------------------------------------------- : PackItemCounter
/// Class for generating card packs
class PackItemGenerator : PackItemCache {
public:
PackItemGenerator(Set& set, vector<CardP>& cards, boost::mt19937& gen)
: PackItemCache(set), out(cards), gen(gen)
{}
/// Generate a pack, adding it to cards
void generate(const PackType& pack);
/// Number of cards of a type
typedef map<pair<ScriptValueP,PackSelectType>,int> OfTypeCount;
/// Determine what *types* of cards to pick (store in out)
/** Does NOT add cards yet.
* Returns true if non-empty.
*/
bool generateCount(const PackType& pack, int copies, PackSelectType type, OfTypeCount& out);
bool generateCount(const PackItem& item, int copies, PackSelectType type, OfTypeCount& out);
bool generateSingleCount(const PackType& pack, PackSelectType type, OfTypeCount& out);
/// Pick cards from a list
void pickCards(const ScriptValueP& cards, PackSelectType type, int amount);
/// The cards will be stored here
vector<CardP>& out;
/// Random generator
boost::mt19937& gen;
}; };
// ----------------------------------------------------------------------------- : EOF // ----------------------------------------------------------------------------- : EOF
......
...@@ -88,10 +88,14 @@ void RandomCardList::getItems(vector<VoidP>& out) const { ...@@ -88,10 +88,14 @@ void RandomCardList::getItems(vector<VoidP>& out) const {
class PackTotalsPanel : public wxPanel { class PackTotalsPanel : public wxPanel {
public: public:
#if USE_NEW_PACK_SYSTEM
PackTotalsPanel(Window* parent, int id, PackGenerator& generator) : wxPanel(parent,id), generator(generator) {}
#else
PackTotalsPanel(Window* parent, int id) : wxPanel(parent,id) {} PackTotalsPanel(Window* parent, int id) : wxPanel(parent,id) {}
#endif
void setGame(const GameP& game); void setGame(const GameP& game);
void clear();
#if !USE_NEW_PACK_SYSTEM #if !USE_NEW_PACK_SYSTEM
void clear();
void addPack(PackType& pack, int copies); void addPack(PackType& pack, int copies);
void addItemRef(PackItemRef& item, int copies); void addItemRef(PackItemRef& item, int copies);
#endif #endif
...@@ -101,12 +105,11 @@ class PackTotalsPanel : public wxPanel { ...@@ -101,12 +105,11 @@ class PackTotalsPanel : public wxPanel {
void onPaint(wxPaintEvent&); void onPaint(wxPaintEvent&);
void draw(DC& dc); void draw(DC& dc);
void drawItem(DC& dc, int& y, const String& name, double value); void drawItem(DC& dc, int& y, const String& name, double value);
#if USE_NEW_PACK_SYSTEM #if USE_NEW_PACK_SYSTEM
public: PackGenerator& generator;
map<const PackType*,double> amounts; #else
#else
map<String,int> amounts; map<String,int> amounts;
#endif #endif
}; };
void PackTotalsPanel::onPaint(wxPaintEvent&) { void PackTotalsPanel::onPaint(wxPaintEvent&) {
...@@ -126,10 +129,10 @@ void PackTotalsPanel::draw(DC& dc) { ...@@ -126,10 +129,10 @@ void PackTotalsPanel::draw(DC& dc) {
int total = 0; int total = 0;
#if USE_NEW_PACK_SYSTEM #if USE_NEW_PACK_SYSTEM
FOR_EACH(pack, game->pack_types) { FOR_EACH(pack, game->pack_types) {
if (pack->summary) { PackInstance& i = generator.get(pack);
int value = amounts[pack.get()]; if (pack->summary && i.has_cards()) {
drawItem(dc, y, tr(*game, pack->name, capitalize), value); drawItem(dc, y, tr(*game, pack->name, capitalize), i.get_card_copies());
total += value; total += (int)i.get_card_copies();
} }
} }
#else #else
...@@ -160,12 +163,14 @@ void PackTotalsPanel::drawItem(DC& dc, int& y, const String& name, double value ...@@ -160,12 +163,14 @@ void PackTotalsPanel::drawItem(DC& dc, int& y, const String& name, double value
void PackTotalsPanel::setGame(const GameP& game) { void PackTotalsPanel::setGame(const GameP& game) {
this->game = game; this->game = game;
#if !USE_NEW_PACK_SYSTEM
clear(); clear();
} #endif
void PackTotalsPanel::clear() {
amounts.clear();
} }
#if !USE_NEW_PACK_SYSTEM #if !USE_NEW_PACK_SYSTEM
void PackTotalsPanel::clear() {
amounts.clear();
}
void PackTotalsPanel::addPack(PackType& pack, int copies) { void PackTotalsPanel::addPack(PackType& pack, int copies) {
FOR_EACH(item,pack.items) { FOR_EACH(item,pack.items) {
addItemRef(*item, copies * item->amount); addItemRef(*item, copies * item->amount);
...@@ -196,7 +201,11 @@ void RandomPackPanel::initControls() { ...@@ -196,7 +201,11 @@ void RandomPackPanel::initControls() {
seed_random = new wxRadioButton(this, ID_SEED_RANDOM, _BUTTON_("random seed")); seed_random = new wxRadioButton(this, ID_SEED_RANDOM, _BUTTON_("random seed"));
seed_fixed = new wxRadioButton(this, ID_SEED_FIXED, _BUTTON_("fixed seed")); seed_fixed = new wxRadioButton(this, ID_SEED_FIXED, _BUTTON_("fixed seed"));
seed = new wxTextCtrl(this, wxID_ANY); seed = new wxTextCtrl(this, wxID_ANY);
#if USE_NEW_PACK_SYSTEM
totals = new PackTotalsPanel(this, wxID_ANY, generator);
#else
totals = new PackTotalsPanel(this, wxID_ANY); totals = new PackTotalsPanel(this, wxID_ANY);
#endif
static_cast<SetWindow*>(GetParent())->setControlStatusText(seed_random, _HELP_("random seed")); static_cast<SetWindow*>(GetParent())->setControlStatusText(seed_random, _HELP_("random seed"));
static_cast<SetWindow*>(GetParent())->setControlStatusText(seed_fixed, _HELP_("fixed seed")); static_cast<SetWindow*>(GetParent())->setControlStatusText(seed_fixed, _HELP_("fixed seed"));
static_cast<SetWindow*>(GetParent())->setControlStatusText(seed, _HELP_("seed")); static_cast<SetWindow*>(GetParent())->setControlStatusText(seed, _HELP_("seed"));
...@@ -259,13 +268,19 @@ void RandomPackPanel::onChangeSet() { ...@@ -259,13 +268,19 @@ void RandomPackPanel::onChangeSet() {
// add pack controls // add pack controls
FOR_EACH(pack, set->game->pack_types) { FOR_EACH(pack, set->game->pack_types) {
PackItem i; #if NEW_PACK_SYSTEM
i.pack = pack; if (pack->selectable) {
i.label = new wxStaticText(this, wxID_ANY, capitalize_sentence(pack->name)); #endif
i.value = new wxSpinCtrl(this, ID_PACK_AMOUNT, _("0"), wxDefaultPosition, wxSize(50,-1)); PackItem i;
packsSizer->Add(i.label, 0, wxALIGN_CENTER_VERTICAL); i.pack = pack;
packsSizer->Add(i.value, 0, wxEXPAND | wxALIGN_CENTER); i.label = new wxStaticText(this, wxID_ANY, capitalize_sentence(pack->name));
packs.push_back(i); i.value = new wxSpinCtrl(this, ID_PACK_AMOUNT, _("0"), wxDefaultPosition, wxSize(50,-1));
packsSizer->Add(i.label, 0, wxALIGN_CENTER_VERTICAL);
packsSizer->Add(i.value, 0, wxEXPAND | wxALIGN_CENTER);
packs.push_back(i);
#if NEW_PACK_SYSTEM
}
#endif
} }
Layout(); Layout();
...@@ -280,6 +295,9 @@ void RandomPackPanel::onChangeSet() { ...@@ -280,6 +295,9 @@ void RandomPackPanel::onChangeSet() {
i.value->SetValue(gs.pack_amounts[i.pack->name]); i.value->SetValue(gs.pack_amounts[i.pack->name]);
} }
#if USE_NEW_PACK_SYSTEM
generator.reset(set,0);
#endif
updateTotals(); updateTotals();
} }
...@@ -328,20 +346,22 @@ void RandomPackPanel::onCommand(int id) { ...@@ -328,20 +346,22 @@ void RandomPackPanel::onCommand(int id) {
// ----------------------------------------------------------------------------- : Generating // ----------------------------------------------------------------------------- : Generating
void RandomPackPanel::updateTotals() { void RandomPackPanel::updateTotals() {
#if USE_NEW_PACK_SYSTEM #if !USE_NEW_PACK_SYSTEM
PackItemCounter counter(*set, totals->amounts);
#endif
totals->clear(); totals->clear();
total_packs = 0; #endif
int total_packs = 0;
FOR_EACH(i,packs) { FOR_EACH(i,packs) {
int copies = i.value->GetValue(); int copies = i.value->GetValue();
total_packs += copies; total_packs += copies;
#if USE_NEW_PACK_SYSTEM #if USE_NEW_PACK_SYSTEM
counter.addCountRecursive(*i.pack, copies); generator.get(i.pack).request_copy(copies);
#else #else
totals->addPack(*i.pack, copies); totals->addPack(*i.pack, copies);
#endif #endif
} }
#if USE_NEW_PACK_SYSTEM
generator.update_card_counts();
#endif
// update UI // update UI
totals->Refresh(false); totals->Refresh(false);
generate_button->Enable(total_packs > 0); generate_button->Enable(total_packs > 0);
...@@ -373,10 +393,10 @@ void RandomPackPanel::setSeed(int seed) { ...@@ -373,10 +393,10 @@ void RandomPackPanel::setSeed(int seed) {
} }
void RandomPackPanel::generate() { void RandomPackPanel::generate() {
boost::mt19937 gen((unsigned)getSeed());
#if USE_NEW_PACK_SYSTEM #if USE_NEW_PACK_SYSTEM
PackItemGenerator generator(*set, card_list->cards, gen); generator.reset(set,getSeed());
#else #else
boost::mt19937 gen((unsigned)getSeed());
PackItemCache pack_cache(*set); PackItemCache pack_cache(*set);
#endif #endif
// add packs to card list // add packs to card list
...@@ -385,7 +405,8 @@ void RandomPackPanel::generate() { ...@@ -385,7 +405,8 @@ void RandomPackPanel::generate() {
int copies = item.value->GetValue(); int copies = item.value->GetValue();
for (int i = 0 ; i < copies ; ++i) { for (int i = 0 ; i < copies ; ++i) {
#if USE_NEW_PACK_SYSTEM #if USE_NEW_PACK_SYSTEM
generator.generate(*item.pack); generator.get(item.pack).request_copy();
generator.generate(card_list->cards);
#else #else
card_list->add(pack_cache, gen, *item.pack); card_list->add(pack_cache, gen, *item.pack);
#endif #endif
......
...@@ -11,6 +11,7 @@ ...@@ -11,6 +11,7 @@
#include <util/prec.hpp> #include <util/prec.hpp>
#include <gui/set/panel.hpp> #include <gui/set/panel.hpp>
#include <data/pack.hpp>
#include <wx/spinctrl.h> #include <wx/spinctrl.h>
class CardViewer; class CardViewer;
...@@ -66,7 +67,9 @@ class RandomPackPanel : public SetWindowPanel { ...@@ -66,7 +67,9 @@ class RandomPackPanel : public SetWindowPanel {
}; };
vector<PackItem> packs; vector<PackItem> packs;
int total_packs; #if USE_NEW_PACK_SYSTEM
PackGenerator generator;
#endif
/// Actual intialization of the controls /// Actual intialization of the controls
void initControls(); void initControls();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment