Skip to content

N
Neos
Merged
Opened by Chunchi Che@SKTT1Ryze
Report abuse

optimize some implementation, including paths of components and so on

@BBeretta Hello, my friend. I have reviewed the MR !372 (merged) and was impressed with the well-organized code, great job! What's more, after reviewing the MR, some ideas which could make the MR better come outs from my head. So i create this MR to add some optimizations to your branch, including:

  1. Moving the new component(LanguageContext, LanguageSelector, etc.) and translation files(/src/Translation) under src/ui path, which could be more well-organized;
  2. Renaming some component, like LanguageContext -> I18NContext, which could be more concise;
  3. Changing the styles of LanguageSelector, which could be more coordinated;
  4. Fixing some names of keys in translations.

It depends on you whether this MR is merged, and if it's done, we can merge MR !372 (merged) without fixing anything.

Best wishes for you!