Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
N
Neos
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 2
    • Merge Requests 2
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Packages
    • Packages
    • List
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issues
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • MyCard
  • Neos
  • Merge Requests
  • !226

Merged
Opened Jun 18, 2023 by timel@timel
  • Report abuse
Report abuse

更新一波动画和样式

  • Overview 8
  • Commits 101
  • Pipelines 73
  • Changes 96
  • 重构SelectActionModal,让调用方法变成await displaySelectActionModal(args),并且去除在messageStore之中的相关代码。

目标是先尝试构造这样一个范式:message相关组件的store各自隐藏在自己的内部,外部通过一个异步函数来调用message并得到可能的返回结果。

好处是无需外部访问store,并且变成异步之后,message的展示和隐藏也变成了一段动画序列,方便后续开发。

现在给这个组件传参,依靠的并不是直接改变组件的入参,而是改变组件的局部store。为什么要这么绕一圈呢?因为如果是直接改变入参,那么组件不能预先挂载到Neos上,而是要在调用函数时候,手动挂载上去。从Antd的经验来看,这么做组件无法读取到全局的配置provider。

其他:

  • 抽离游戏王卡片为单独的share组件
  • 重新写了一个支持最小化的Modal,用来替代DragModal
  • 重写了chaining动画,从浮起变成了一个渐变扩散的外框
  • (可能)解决了动画中间暂停的问题
  • 微调了决斗盘样式
  • 调整了CardModal样式
Edited Jun 29, 2023 by Chunchi Che

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "dev/async" "origin/dev/async"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/main"
git merge --no-ff "dev/async"

Step 4. Push the result of the merge to GitLab

git push origin "main"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: mycard/Neos!226

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.