fix

src/reducers/duel/commonSlice.ts

@@ -6,6 +6,9 @@ import {
   updateCardData,
 } from "./generic";
 import { judgeSelf } from "./util";
+type MsgUpdateData = ReturnType<
+  typeof ygopro.StocGameMessage.MsgUpdateData.prototype.toObject
+>;
 
 export const clearAllIdleInteractivitiesImpl: DuelReducer<number> = (
   state,
@@ -59,60 +62,65 @@ export const clearAllPlaceInteractivitiesImpl: DuelReducer<number> = (
   states.forEach((item) => clearPlaceInteractivities(item));
 };
 
-export const updateFieldDataImpl: DuelReducer<
-  ygopro.StocGameMessage.MsgUpdateData
-> = (state, action) => {
+export const updateFieldDataImpl: DuelReducer<MsgUpdateData> = (
+  state,
+  action
+) => {
   const player = action.payload.player;
   const zone = action.payload.zone;
   const actions = action.payload.actions;
 
-  switch (zone) {
-    case ygopro.CardZone.HAND: {
-      const hand = judgeSelf(player, state) ? state.meHands : state.opHands;
-      updateCardData(hand, actions);
+  if (player && zone && actions) {
+    switch (zone) {
+      case ygopro.CardZone.HAND: {
+        const hand = judgeSelf(player, state) ? state.meHands : state.opHands;
+        updateCardData(hand, actions);
 
-      break;
-    }
-    case ygopro.CardZone.EXTRA: {
-      const extra = judgeSelf(player, state)
-        ? state.meExtraDeck
-        : state.opExtraDeck;
-      updateCardData(extra, actions);
+        break;
+      }
+      case ygopro.CardZone.EXTRA: {
+        const extra = judgeSelf(player, state)
+          ? state.meExtraDeck
+          : state.opExtraDeck;
+        updateCardData(extra, actions);
 
-      break;
-    }
-    case ygopro.CardZone.MZONE: {
-      const monster = judgeSelf(player, state)
-        ? state.meMonsters
-        : state.opMonsters;
-      updateCardData(monster, actions);
+        break;
+      }
+      case ygopro.CardZone.MZONE: {
+        const monster = judgeSelf(player, state)
+          ? state.meMonsters
+          : state.opMonsters;
+        updateCardData(monster, actions);
 
-      break;
-    }
-    case ygopro.CardZone.SZONE: {
-      const magics = judgeSelf(player, state) ? state.meMagics : state.opMagics;
-      updateCardData(magics, actions);
+        break;
+      }
+      case ygopro.CardZone.SZONE: {
+        const magics = judgeSelf(player, state)
+          ? state.meMagics
+          : state.opMagics;
+        updateCardData(magics, actions);
 
-      break;
-    }
-    case ygopro.CardZone.GRAVE: {
-      const cemetery = judgeSelf(player, state)
-        ? state.meCemetery
-        : state.opCemetery;
-      updateCardData(cemetery, actions);
+        break;
+      }
+      case ygopro.CardZone.GRAVE: {
+        const cemetery = judgeSelf(player, state)
+          ? state.meCemetery
+          : state.opCemetery;
+        updateCardData(cemetery, actions);
 
-      break;
-    }
-    case ygopro.CardZone.REMOVED: {
-      const exclusion = judgeSelf(player, state)
-        ? state.meExclusion
-        : state.opExclusion;
-      updateCardData(exclusion, actions);
+        break;
+      }
+      case ygopro.CardZone.REMOVED: {
+        const exclusion = judgeSelf(player, state)
+          ? state.meExclusion
+          : state.opExclusion;
+        updateCardData(exclusion, actions);
 
-      break;
-    }
-    default: {
-      break;
+        break;
+      }
+      default: {
+        break;
+      }
     }
   }
 };

src/reducers/duel/generic.ts

@@ -8,7 +8,9 @@ import { CardMeta } from "../../api/cards";
 import { ygopro } from "../../api/ocgcore/idl/ocgcore";
 import { fetchCard } from "../../api/cards";
 import { DuelState } from "./mod";
-import UpdateDataAction = ygopro.StocGameMessage.MsgUpdateData.Action;
+type UpdateDataAction = ReturnType<
+  typeof ygopro.StocGameMessage.MsgUpdateData.Action.prototype.toObject
+>;
 
 export type DuelReducer<T> = CaseReducer<DuelState, PayloadAction<T>>;
 
@@ -289,8 +291,7 @@ export function updateCardData<T extends DuelFieldState>(
   state: T | undefined,
   actions: UpdateDataAction[]
 ) {
-  for (const action of actions) {
-    const payload = action.toObject();
+  for (const payload of actions) {
     const sequence = payload.location?.sequence;
     if (typeof sequence !== "undefined") {
       const target = state?.inner.find((_, idx) => idx == sequence);