Merge branch 'fix/crash' into 'main'

fix removeChild crash See merge request !314

Merge branch 'fix/crash' into 'main'
fix removeChild crash See merge request !314
551fc976 · Chunchi Che · 766e285b · ca49622c · 551fc976
Commit 551fc976 authored Sep 13, 2023 by Chunchi Che
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

src/ui/Shared/Background/index.tsx src/ui/Shared/Background/index.tsx +4 -1

No files found.
--- a/src/ui/Shared/Background/index.tsx
+++ b/src/ui/Shared/Background/index.tsx
@@ -22,7 +22,10 @@ export const withPortalToBody = <P extends object>(
      return () => {
        // 卸载组件并且移除容器
        setTimeout(() => root.unmount());
-        portalRoot.removeChild(newNode);
+        if (portalRoot.contains(newNode)) {
+          // 做个if判断，防止下面这行crash
+          portalRoot.removeChild(newNode);
+        }
      };
    }, []);