Commit db34c105 authored by Miek Gieben's avatar Miek Gieben Committed by GitHub

server: small cleanups (#2740)

Rename connTimeout to graceTimeout to be more instructive on it's use,
some whitespace for imports lines.
Signed-off-by: default avatarMiek Gieben <miek@miek.nl>
parent c5bad4f8
...@@ -9,6 +9,7 @@ import ( ...@@ -9,6 +9,7 @@ import (
"syscall" "syscall"
"github.com/coredns/coredns/plugin/pkg/log" "github.com/coredns/coredns/plugin/pkg/log"
"golang.org/x/sys/unix" "golang.org/x/sys/unix"
) )
......
...@@ -35,7 +35,7 @@ type Server struct { ...@@ -35,7 +35,7 @@ type Server struct {
zones map[string]*Config // zones keyed by their address zones map[string]*Config // zones keyed by their address
dnsWg sync.WaitGroup // used to wait on outstanding connections dnsWg sync.WaitGroup // used to wait on outstanding connections
connTimeout time.Duration // the maximum duration of a graceful shutdown graceTimeout time.Duration // the maximum duration of a graceful shutdown
trace trace.Trace // the trace plugin for the server trace trace.Trace // the trace plugin for the server
debug bool // disable recover() debug bool // disable recover()
classChaos bool // allow non-INET class queries classChaos bool // allow non-INET class queries
...@@ -48,7 +48,7 @@ func NewServer(addr string, group []*Config) (*Server, error) { ...@@ -48,7 +48,7 @@ func NewServer(addr string, group []*Config) (*Server, error) {
s := &Server{ s := &Server{
Addr: addr, Addr: addr,
zones: make(map[string]*Config), zones: make(map[string]*Config),
connTimeout: 5 * time.Second, // TODO(miek): was configurable graceTimeout: 5 * time.Second,
} }
// We have to bound our wg with one increment // We have to bound our wg with one increment
...@@ -163,7 +163,7 @@ func (s *Server) Stop() (err error) { ...@@ -163,7 +163,7 @@ func (s *Server) Stop() (err error) {
// Wait for remaining connections to finish or // Wait for remaining connections to finish or
// force them all to close after timeout // force them all to close after timeout
select { select {
case <-time.After(s.connTimeout): case <-time.After(s.graceTimeout):
case <-done: case <-done:
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment