fix external service type check (#1246)

plugin/kubernetes/handler_test.go

@@ -288,6 +288,7 @@ var svcIndex = map[string][]*api.Service{
 				Protocol: "tcp",
 				Port:     80,
 			}},
+			Type: api.ServiceTypeExternalName,
 		},
 	}},
 }

plugin/kubernetes/kubernetes.go

@@ -418,16 +418,15 @@ func (k *Kubernetes) findServices(r recordRequest, zone string) (services []msg.
 		}
 
 		// External service
-		if svc.Spec.ExternalName != "" {
+		if svc.Spec.Type == api.ServiceTypeExternalName {
 			s := msg.Service{Key: strings.Join([]string{zonePath, Svc, svc.Namespace, svc.Name}, "/"), Host: svc.Spec.ExternalName, TTL: k.ttl}
 			if t, _ := s.HostType(); t == dns.TypeCNAME {
 				s.Key = strings.Join([]string{zonePath, Svc, svc.Namespace, svc.Name}, "/")
 				services = append(services, s)
 
 				err = nil
-
-				continue
 			}
+			continue
 		}
 
 		// ClusterIP service

plugin/kubernetes/kubernetes_test.go

@@ -101,6 +101,7 @@ func (APIConnServiceTest) SvcIndex(string) []*api.Service {
 					Protocol: "tcp",
 					Port:     80,
 				}},
+				Type: api.ServiceTypeExternalName,
 			},
 		},
 	}
@@ -144,6 +145,7 @@ func (APIConnServiceTest) ServiceList() []*api.Service {
 					Protocol: "tcp",
 					Port:     80,
 				}},
+				Type: api.ServiceTypeExternalName,
 			},
 		},
 	}