Merge remote-tracking branch 'upstream/patch-ocgapi' into develop

.github/workflows/build.yml

@@ -18,17 +18,16 @@ jobs:
 
     - name: Install lua
       run: |
-        bash -c "curl --retry 5 --connect-timeout 30 --location --remote-header-name --remote-name https://www.lua.org/ftp/lua-5.4.7.tar.gz ; exit 0"
-        tar xzf lua-5.4.7.tar.gz
+        bash -c "curl -Z --retry 5 --connect-timeout 30 --location --create-dirs --output-dir temp --remote-name-all https://www.lua.org/ftp/lua-5.4.7.tar.gz https://github.com/premake/premake-core/releases/download/v5.0.0-beta2/premake-5.0.0-beta2-windows.zip ; exit 0"
+        tar -xzf temp/lua-5.4.7.tar.gz
         move lua-5.4.7 lua
 
     - name: Premake
       run: |
-        bash -c "curl --retry 5 --connect-timeout 30 --location --remote-header-name --remote-name https://github.com/premake/premake-core/releases/download/v5.0.0-beta2/premake-5.0.0-beta2-windows.zip ; exit 0"
-        7z x premake-5.0.0-beta2-windows.zip
-        move premake\lua.lua lua\premake5.lua
-        move premake\dll.lua dll.lua
-        .\premake5.exe vs2022 --file=dll.lua
+        7z x temp/premake-5.0.0-beta2-windows.zip -opremake-5
+        move premake/lua.lua lua/premake5.lua
+        move premake/dll.lua dll.lua
+        ./premake-5/premake5.exe vs2022 --file=dll.lua
 
     - name: Add msbuild to PATH
       uses: microsoft/setup-msbuild@v2

.gitignore

-.vscode/
+/.vscode/
+/build/
+/lua/
+/temp/
+/premake-5/
 /premake5.exe
-/build
-/lua

ocgapi.cpp

@@ -192,7 +192,7 @@ extern "C" DECL_DLLEXPORT void new_tag_card(intptr_t pduel, uint32_t code, uint8
 }
 /**
 * @brief Get card information.
-* @param buf uint32_t array
+* @param buf int32_t array
 * @return buffer length in bytes
 */
 extern "C" DECL_DLLEXPORT int32_t query_card(intptr_t pduel, uint8_t playerid, uint8_t location, uint8_t sequence, int32_t query_flag, byte* buf, int32_t use_cache) {
@@ -201,7 +201,7 @@ extern "C" DECL_DLLEXPORT int32_t query_card(intptr_t pduel, uint8_t playerid, u
 	duel* ptduel = (duel*)pduel;
 	card* pcard = nullptr;
 	location &= 0x7f;
-	if(location & LOCATION_ONFIELD)
+	if (location == LOCATION_MZONE || location == LOCATION_SZONE)
 		pcard = ptduel->game_field->get_field_card(playerid, location, sequence);
 	else {
 		card_vector* lst = nullptr;
@@ -217,9 +217,8 @@ extern "C" DECL_DLLEXPORT int32_t query_card(intptr_t pduel, uint8_t playerid, u
 			lst = &ptduel->game_field->player[playerid].list_main;
 		else
 			return LEN_FAIL;
-		if(sequence >= (int32_t)lst->size())
-			pcard = nullptr;
-		else
+		if (sequence >= (int32_t)lst->size())
+			return LEN_FAIL;
 		pcard = (*lst)[sequence];
 	}
 	if (pcard) {