Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
D
Dnsmasq
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Packages
Packages
List
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issues
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
nanahira
Dnsmasq
Commits
5f938534
Commit
5f938534
authored
Feb 03, 2014
by
Simon Kelley
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Return configured DNSKEYs even though we don't have RRSIGS for them.
parent
8d718cbb
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
68 additions
and
66 deletions
+68
-66
src/blockdata.c
src/blockdata.c
+1
-2
src/cache.c
src/cache.c
+1
-1
src/rfc1035.c
src/rfc1035.c
+66
-63
No files found.
src/blockdata.c
View file @
5f938534
...
@@ -73,8 +73,7 @@ struct blockdata *blockdata_alloc(char *data, size_t len)
...
@@ -73,8 +73,7 @@ struct blockdata *blockdata_alloc(char *data, size_t len)
keyblock_free
=
block
->
next
;
keyblock_free
=
block
->
next
;
blockdata_count
++
;
blockdata_count
++
;
}
}
else
if
(
!
block
)
{
{
/* failed to alloc, free partial chain */
/* failed to alloc, free partial chain */
blockdata_free
(
ret
);
blockdata_free
(
ret
);
...
...
src/cache.c
View file @
5f938534
...
@@ -486,7 +486,7 @@ struct crec *cache_insert(char *name, struct all_addr *addr,
...
@@ -486,7 +486,7 @@ struct crec *cache_insert(char *name, struct all_addr *addr,
insert. Once in this state, all inserts will probably fail. */
insert. Once in this state, all inserts will probably fail. */
if
(
free_avail
)
if
(
free_avail
)
{
{
static
warned
=
0
;
static
int
warned
=
0
;
if
(
!
warned
)
if
(
!
warned
)
{
{
my_syslog
(
LOG_ERR
,
_
(
"Internal error in cache."
));
my_syslog
(
LOG_ERR
,
_
(
"Internal error in cache."
));
...
...
src/rfc1035.c
View file @
5f938534
...
@@ -1553,23 +1553,24 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
...
@@ -1553,23 +1553,24 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
#ifdef HAVE_DNSSEC
#ifdef HAVE_DNSSEC
if
(
option_bool
(
OPT_DNSSEC_VALID
)
&&
(
qtype
==
T_DNSKEY
||
qtype
==
T_DS
||
qtype
==
T_RRSIG
))
if
(
option_bool
(
OPT_DNSSEC_VALID
)
&&
(
qtype
==
T_DNSKEY
||
qtype
==
T_DS
||
qtype
==
T_RRSIG
))
{
{
int
gotone
=
0
;
int
gotone
=
0
,
have_rrsig
=
0
;
struct
blockdata
*
keydata
;
struct
blockdata
*
keydata
;
/* Do we have RRSIG? Can't do DS or DNSKEY otherwise. */
/* Do we have RRSIG? Can't do DS or DNSKEY otherwise. */
crecp
=
NULL
;
crecp
=
NULL
;
while
((
crecp
=
cache_find_by_name
(
crecp
,
name
,
now
,
F_DNSKEY
|
F_DS
)))
while
((
crecp
=
cache_find_by_name
(
crecp
,
name
,
now
,
F_DNSKEY
|
F_DS
)))
if
(
crecp
->
uid
==
qclass
&&
(
qtype
==
T_RRSIG
||
crecp
->
addr
.
sig
.
type_covered
==
qtype
))
if
(
crecp
->
uid
==
qclass
&&
(
qtype
==
T_RRSIG
||
crecp
->
addr
.
sig
.
type_covered
==
qtype
))
{
have_rrsig
=
1
;
break
;
break
;
}
if
(
crecp
)
if
(
qtype
==
T_RRSIG
&&
have_rrsig
)
{
if
(
qtype
==
T_RRSIG
)
{
{
ans
=
gotone
=
1
;
ans
=
gotone
=
1
;
auth
=
0
;
auth
=
0
;
}
}
else
if
(
qtype
==
T_DS
)
else
if
(
qtype
==
T_DS
&&
have_rrsig
)
{
{
auth
=
0
;
auth
=
0
;
crecp
=
NULL
;
crecp
=
NULL
;
...
@@ -1596,10 +1597,12 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
...
@@ -1596,10 +1597,12 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
crecp
=
NULL
;
crecp
=
NULL
;
while
((
crecp
=
cache_find_by_name
(
crecp
,
name
,
now
,
F_DNSKEY
)))
while
((
crecp
=
cache_find_by_name
(
crecp
,
name
,
now
,
F_DNSKEY
)))
if
(
crecp
->
uid
==
qclass
)
if
(
crecp
->
uid
==
qclass
)
{
if
((
crecp
->
flags
&
F_CONFIG
)
||
have_rrsig
)
/* Return configured keys without an RRISG */
{
{
if
(
!
(
crecp
->
flags
&
F_CONFIG
))
if
(
!
(
crecp
->
flags
&
F_CONFIG
))
auth
=
0
;
auth
=
0
,
gotone
=
1
;
ans
=
gotone
=
1
;
ans
=
1
;
if
(
!
dryrun
&&
(
keydata
=
blockdata_retrieve
(
crecp
->
addr
.
key
.
keydata
,
crecp
->
addr
.
key
.
keylen
,
NULL
)))
if
(
!
dryrun
&&
(
keydata
=
blockdata_retrieve
(
crecp
->
addr
.
key
.
keydata
,
crecp
->
addr
.
key
.
keylen
,
NULL
)))
{
{
struct
all_addr
a
;
struct
all_addr
a
;
...
@@ -1613,6 +1616,7 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
...
@@ -1613,6 +1616,7 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
}
}
}
}
}
}
}
/* Now do RRSIGs */
/* Now do RRSIGs */
if
(
gotone
)
if
(
gotone
)
...
@@ -1637,7 +1641,6 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
...
@@ -1637,7 +1641,6 @@ size_t answer_request(struct dns_header *header, char *limit, size_t qlen,
}
}
}
}
}
}
}
#endif
#endif
if
(
qclass
==
C_IN
)
if
(
qclass
==
C_IN
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment