Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Sign in / Register
Toggle navigation
M
miniaudio
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Locked Files
Issues
0
Issues
0
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Security & Compliance
Security & Compliance
Dependency List
License Compliance
Packages
Packages
List
Container Registry
Analytics
Analytics
CI / CD
Code Review
Insights
Issues
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
MyCard
miniaudio
Commits
0455697b
Commit
0455697b
authored
May 24, 2020
by
David Reid
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update contribution guidelines to be a bit more professional.
parent
3f96bdf8
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
54 additions
and
13 deletions
+54
-13
CONTRIBUTING.md
CONTRIBUTING.md
+50
-13
docs/CODE_OF_CONDUCT.md
docs/CODE_OF_CONDUCT.md
+4
-0
No files found.
CONTRIBUTING.md
View file @
0455697b
Contributing to miniaudio
Contributing to miniaudio
=========================
=========================
First of all, thanks for stopping by! This document will explain a few things to consider when contributing to
miniaudio.
Found a Bug?
Found a Bug?
------------
------------
...
@@ -14,14 +17,18 @@ get the bug fixed. See the next section for guidance on pull requests.
...
@@ -14,14 +17,18 @@ get the bug fixed. See the next section for guidance on pull requests.
Pull Requests
Pull Requests
-------------
-------------
If you want to do actual development on miniaudio, pull requests are the best place to start. Just don't do any
If you want to do actual development on miniaudio, pull requests are the best place to start. Just don't do any
significant work without talking to me first. If I don't like it, it won't be merged. Always base your pull
significant work without talking to me first. If I don't like it, it won't be merged. You can find me via email,
request branch on the "dev" branch. The master branch contains the latest release, which means your pull request
[
Discord
](
https://discord.gg/9vpqbjU
)
and
[
Twitter
](
https://twitter.com/mackron
)
.
may not be including the lastest in-development changes which may result in unnecessary conflicts.
Always base your pull request branch on the "dev" branch. The master branch contains the latest release, which
means your pull request may not be including the lastest in-development changes which may result in unnecessary
conflicts.
I need to review your pull requests before merging. If your pull request is non-trivial, try to break it up into
I need to review your pull requests before merging. If your pull request is non-trivial, try to break it up into
logical bite sized commits to make it easier for review, but make sure every commit compiles.
logical bite sized commits to make it easier for review, but make sure every commit compiles. Obviously this is
not always easy to do in practice, but just keep it in mind.
When it comes to coding style I'm fairly relaxed, but be
a
professional and respect the existing coding style,
When it comes to coding style I'm fairly relaxed, but be professional and respect the existing coding style,
regardless of whether or not you like it. It's no big deal if something slips, but try to keep it in mind. Some
regardless of whether or not you like it. It's no big deal if something slips, but try to keep it in mind. Some
things in particular:
things in particular:
*
C89.
`/*...*/`
style comments and variables declared at the top of the code block are the main thing.
*
C89.
`/*...*/`
style comments and variables declared at the top of the code block are the main thing.
...
@@ -31,6 +38,19 @@ things in particular:
...
@@ -31,6 +38,19 @@ things in particular:
I'm not going to outline specific coding styles - just look at the existing code and use common sense.
I'm not going to outline specific coding styles - just look at the existing code and use common sense.
Respect the Goals of the Project
--------------------------------
When making a contribution, please respect the primary goals of the project. These are the points of difference
that make miniaudio unique and it's important they're maintained and respected.
*
miniaudio is
*single file*
. Do not split your work into multiple files thinking I'll be impressed with your
modular design - I won't, and your contribution will be immediately rejected.
*
miniaudio has
*no external dependencies*
. You might think your helping by adding some cool new feature via
some external library. You're not helping, and your contribution will be immediately rejected.
*
miniaudio is
*public domain*
. Don't add any code that's taken directly from licensed code.
Licensing and Credits
Licensing and Credits
---------------------
---------------------
miniaudio is dual licensed as a choice of public domain or MIT-0 (No Attribution), so you need to agree to release
miniaudio is dual licensed as a choice of public domain or MIT-0 (No Attribution), so you need to agree to release
...
@@ -38,11 +58,28 @@ your contributions as such. I also do not maintain a credit/contributions list.
...
@@ -38,11 +58,28 @@ your contributions as such. I also do not maintain a credit/contributions list.
not contribute to this project.
not contribute to this project.
Before You Ask:
Predictable Questions
---------------
---------------------
*
No, I'm not switching away from C89.
### "Would you consider splitting out [some section of code] into it's own file?"
*
No, I'm not adding a third license option.
No, the idea is to keep everything in one place. It would be nice in specific cases to split out specific sections
*
No, I'm not adding you to any kind of credit list.
of the code, such as the resampler, for example. However, this will completely violate one of the major goals of the
*
No, I'm not splitting the project out into multiple files.
project - to have a complete audio library contained within a single file.
*
No, I'm not adding support for CMake nor any other kind of build system.
*
No, there's no Code of Conduct and I'm not adding one. Just don't be unpleasant.
### "Would you consider adding support for CMake [or my favourite build system]?"
\ No newline at end of file
No, the whole point of having the code contained entirely within a single file and not have any external dependencies
is to make it easy to add to your source tree without needing any extra build system integration. There is no need to
incur the cost of maintaining build systems in miniaudio.
### "Would you consider feature XYZ? It requires C11, but don't worry, all compilers support it."
One of the philosophies of miniaudio is that it should just work, and that includes compilation environment. There's
no real reason to not support support older compilers. Newer versions of C will not add anything of any significance
that cannot already be done in C89.
### "Will you consider adding a third license option such as [my favourite license]?"
No, the idea is to keep licensing simple. That's why miniaudio is public domain - to avoid as much license friction
as possible. However, some regions do not recognize public domain, so therefore an alternative license, MIT No
Attribution, is included as an added option. There is no need to make the licensing situation any more confusing.
### "Is there a list of contributors? Will my name be added to any kind of list?"
No, there's no credit list as it just adds extra maintenance work and it's too easy to accidentally and unfairly
forget to add a contributor. A list of contributors can be retrieved from the Git log and also GitHub itself.
docs/CODE_OF_CONDUCT.md
0 → 100644
View file @
0455697b
Code of Conduct
===============
We don't believe we need a document telling fully grown adults how to conduct themselves within an open source
community. All we ask is that you just don't be unpleasant and keep everything on topic.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment